-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(docker_logs source): add exponential retry to docker client #24063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
titaneric
wants to merge
14
commits into
vectordotdev:master
Choose a base branch
from
titaneric:fix/slow-docker-proxy-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+47
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: titaneric <[email protected]>
Signed-off-by: titaneric <[email protected]>
Signed-off-by: titaneric <[email protected]>
pront
reviewed
Oct 29, 2025
Signed-off-by: titaneric <[email protected]>
Signed-off-by: titaneric <[email protected]>
Signed-off-by: titaneric <[email protected]>
|
Hey @titaneric some small checks are failing. Also, worth testing this locally and see that the actual backoff duration is what we expected. |
Signed-off-by: titaneric <[email protected]>
|
First retry, please note that event API is requested after 2 seconds Second retry after 4 seconds Third retry after 8 seconds |
Signed-off-by: titaneric <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
domain: sources
Anything related to the Vector's sources
source: docker_logs
Anything `docker_logs` source related
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Present
docker_logssource would not retry the request after the event watcher stop (which would cause all container logs streamer stop immediately), and this PR would like to add the exponential backoff retry to reset the event watcher.Vector configuration
How did you test this PR?
download docker proxy and launch it to simulate the slow docker request (bind to
127.0.0.1:2376)open another terminal, and run the vector
AS IS
TO BE
Notice that the event listener would retry after backoff time.
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Closes: #23608 and closes #23847
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details here.