-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix(google): add thought signature to gemini 3 pro image parts #10462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(google): add thought signature to gemini 3 pro image parts #10462
Conversation
|
I verified that Problem is that this will need a spec change because language-model-v3-file.ts does not defined providerMetadata?: SharedV3ProviderMetadata; yet (unlike all other LanguageModelV3Content types) but we would need to pass it via providerMetadata here 6078060/packages/google/src/google-generative-ai-language-model.ts#L268-L274 same way we pass it for function calls above Which means we cannot backport it. Or I'm missing something 🤔 |
…and set it in `convertToGoogleGenerativeAIMessages()`
|
we basically ran into #7979 |
…-gemini-3-pro-image-preview-in-middle-of-a-conversation-breaks-thought_signature
|
I will start the backport pull request, but won't merge until it's absolutely necessary, since the spec change is a breaking change und might cause friction to users unaffected by the bug this fixes. |
|
|
Background
generateText()/streamText()doesn't pass thought signature for image parts in response messages. That breaks multi-turn chats withgemini-3-pro-image-previewSummary
response.messagesLanguageModelV3File#providerMetadata(optional field)Manual Verification
Checklist
pnpm changesetin the project root)Related Issues
Fixes #10441
Closes #7979