Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary task log file missing for commands with colon character #9903

Closed
1 task done
IanMitchell opened this issue Feb 5, 2025 · 3 comments · Fixed by #9907
Closed
1 task done

Summary task log file missing for commands with colon character #9903

IanMitchell opened this issue Feb 5, 2025 · 3 comments · Fixed by #9907
Labels
kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage

Comments

@IanMitchell
Copy link

Verify canary release

  • I verified that the issue exists in the latest Turborepo canary release.

Link to code that reproduces this issue

https://github.com/IanMitchell/summarize-colon-missing-logfile

Which canary version will you have in your reproduction?

[email protected]

Enviroment information

CLI:
   Version: 2.4.1-canary.0
   Path to executable: /Users/ian/Developer/summarize-colon-missing-logfile/node_modules/turbo-darwin-arm64/bin/turbo
   Daemon status: Running
   Package manager: npm

Platform:
   Architecture: aarch64
   Operating system: macos
   WSL: false
   Available memory (MB): 13660
   Available CPU cores: 14

Environment:
   CI: None
   Terminal (TERM): xterm-256color
   Terminal program (TERM_PROGRAM): vscode
   Terminal program version (TERM_PROGRAM_VERSION): 1.96.4
   Shell (SHELL): /opt/homebrew/bin/fish
   stdin: false

Expected behavior

The task log file packages/pkg-a/.turbo/turbo-colon$colon$command.log should exist

Actual behavior

There is no .turbo directory and no log file

To Reproduce

In the linked repro repository, run npm run colon:command

Additional context

While I am unsure if the $colon$ ultimately is responsible, other commands create the associated log files.

@IanMitchell IanMitchell added kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage labels Feb 5, 2025
@IanMitchell IanMitchell changed the title Summary log file missing for commands with colon character Summary task log file missing for commands with colon character Feb 5, 2025
@IanMitchell
Copy link
Author

As a point of clarification, the run summary exists but the task summary doesn't exist within the scoped package. I see "logFile": "packages/pkg-a/.turbo/turbo-colon$colon$command.log",, but that file was never created

@chris-olszewski
Copy link
Member

Your reproduction explicitly disables caching for colon:command. If you have this set, we don't cache any task outputs which includes the task logs.

@IanMitchell
Copy link
Author

IanMitchell commented Feb 6, 2025

Gotcha. I would expect the task run to have a null value for logFile instead of the incorrect path in that case.

Appreciate the quick change there, definitely makes it more intuitive for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants