Skip to content

Evaluate calling places of Image constructors with ImageData #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akoch-yatta opened this issue Jan 21, 2025 · 1 comment · May be fixed by eclipse-platform/eclipse.platform.ui#3004
Assignees
Labels
Enhancement A Request for an Enhancement of an Existing Feature HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT
Milestone

Comments

@akoch-yatta
Copy link

As the scaling of ImageData is a destructive operation all callers of the Image constructors with ImageData (at least in the platform repository) should be checked and evaluated if the call could be replaced with a proper Dynamic alternative with ImageDataProvider, ImageFileNameProvider or a ImageGcDrawer

@akoch-yatta akoch-yatta added Enhancement A Request for an Enhancement of an Existing Feature HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT labels Jan 21, 2025
@akoch-yatta akoch-yatta added this to the 4.36 M1 milestone Jan 21, 2025
@akoch-yatta akoch-yatta moved this to 🔖 Ready: Atomic in HiDPI Jan 21, 2025
@HeikoKlare HeikoKlare modified the milestones: 4.36 M1, 4.36 M2 Feb 24, 2025
@fedejeanne fedejeanne modified the milestones: 4.36 M2, 4.36 M3 Apr 16, 2025
@akoch-yatta akoch-yatta modified the milestones: 4.36 M3, 4.37 M1 May 19, 2025
@arunjose696 arunjose696 self-assigned this May 22, 2025
@arunjose696
Copy link

arunjose696 commented May 23, 2025

One instance where Image(Device, ImageData) is used can be found inside the "Tip of the Day" feature: Slider.java#L385. Currently, tip images are sourced either from PNG files or embedded as base64-encoded data within JSON files (e.g., twittertips.json , tips.json).

While a dynamic image allocation strategy—such as converting base64 entries into separate SVG files—could be explored, this change is being deferred for now. The impact is minimal, and addressing it is outside the scope of the current issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A Request for an Enhancement of an Existing Feature HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT
Projects
Status: 🔖 Ready: Atomic
4 participants