Remove redundant log and leave comment in its place

benjirewis · benjirewis · commit 5c184be6c690 · 2025-10-02T15:14:50.000-04:00
diff --git a/manager.go b/manager.go
@@ -587,7 +587,8 @@ func (m *Manager) StartBackgroundChecks(ctx context.Context) {
 					needsRestartCheckInterval = minimalNeedsRestartCheckInterval
 				}
 				if needsRestart {
-					m.logger.Infof("%s restart was requested from app; forcibly restarting now", SubsystemName)
+					// Do not mark m.agentNeedsRestart and instead Exit immediately; we do not want
+					// to wait for viam-server to allow a restart as it may be in a bad state.
 					m.Exit(fmt.Sprintf("A restart of %s was requested from app", SubsystemName))
 				}
 				// As with the device agent config check interval, randomly fuzz the interval by

Original file line number	Diff line number	Diff line change
`@@ -587,7 +587,8 @@ func (m *Manager) StartBackgroundChecks(ctx context.Context) {`
`587`	`587`	`needsRestartCheckInterval = minimalNeedsRestartCheckInterval`
`588`	`588`	`}`
`589`	`589`	`if needsRestart {`
`590`		`- m.logger.Infof("%s restart was requested from app; forcibly restarting now", SubsystemName)`
	`590`	`+ // Do not mark m.agentNeedsRestart and instead Exit immediately; we do not want`
	`591`	`+ // to wait for viam-server to allow a restart as it may be in a bad state.`
`591`	`592`	`m.Exit(fmt.Sprintf("A restart of %s was requested from app", SubsystemName))`
`592`	`593`	`}`
`593`	`594`	`// As with the device agent config check interval, randomly fuzz the interval by`