APP-9929 respect etags in resumable downloads #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
outline: |
abe-winter
reviewed
Nov 17, 2025
utils/utils_test.go
Outdated
|
|
||
| func TestPartialPath(t *testing.T) { | ||
| path := CreatePartialPath("https://storage.googleapis.com/packages.viam.com/apps/viam-server/viam-server-latest-x86_64") | ||
| path, _ := CreatePartialPath("https://storage.googleapis.com/packages.viam.com/apps/viam-server/viam-server-latest-x86_64") |
Member
There was a problem hiding this comment.
on L395 below, can you add another line testing the etag path as well as the partial path?
utils/utils.go
Outdated
|
|
||
| return path.Join(ViamDirs.Partials, hashString(rawURL, 7), last(strings.Split(urlPath, "/"), "")+".part") | ||
| partPath = path.Join(ViamDirs.Partials, hashString(rawURL, 7), last(strings.Split(urlPath, "/"), "")+".part") | ||
| etagPath = partPath + ".etag" |
Member
There was a problem hiding this comment.
here, can you do something like
basePath := path.Join(whatever)
partPath = basePath + ".part"
etagPath = basePath + ".etag"(so that the etag isn't .part.etag)
- Modified CreatePartialPath to return both .part and .etag paths - Added HEAD request to check remote ETag before downloading - Store ETag when starting downloads and check it when resuming - Delete partial file and start fresh if ETag mismatch detected - Updated tests to verify both partial and ETag path lengths
…syntax" This reverts commit 891d034.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.