Skip to content

Commit aee7ae3

Browse files
committed
Remove GetImage, Format, and RenderFrame from camera.proto
1 parent e1124ae commit aee7ae3

File tree

1 file changed

+1
-38
lines changed

1 file changed

+1
-38
lines changed

proto/viam/component/camera/v1/camera.proto

Lines changed: 1 addition & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -12,22 +12,10 @@ option java_package = "com.viam.component.camera.v1";
1212

1313
// A CameraService services all cameras associated with a robot
1414
service CameraService {
15-
// GetImage returns a frame from a camera of the underlying robot. A specific MIME type
16-
// can be requested but may not necessarily be the same one returned.
17-
rpc GetImage(GetImageRequest) returns (GetImageResponse) {
18-
option (google.api.http) = {get: "/viam/api/v1/component/camera/{name}/image"};
19-
}
20-
2115
rpc GetImages(GetImagesRequest) returns (GetImagesResponse) {
2216
option (google.api.http) = {get: "/viam/api/v1/component/camera/{name}/images"};
2317
}
2418

25-
// RenderFrame renders a frame from a camera of the underlying robot to an HTTP response. A specific MIME type
26-
// can be requested but may not necessarily be the same one returned.
27-
rpc RenderFrame(RenderFrameRequest) returns (google.api.HttpBody) {
28-
option (google.api.http) = {get: "/viam/api/v1/component/camera/{name}/render_frame"};
29-
}
30-
3119
// GetPointCloud returns a point cloud from a camera of the underlying robot. A specific MIME type
3220
// can be requested but may not necessarily be the same one returned.
3321
rpc GetPointCloud(GetPointCloudRequest) returns (GetPointCloudResponse) {
@@ -50,22 +38,6 @@ service CameraService {
5038
}
5139
}
5240

53-
message GetImageRequest {
54-
// Name of a camera
55-
string name = 1;
56-
// Requested MIME type of response
57-
string mime_type = 2;
58-
// Additional arguments to the method
59-
google.protobuf.Struct extra = 99;
60-
}
61-
62-
message GetImageResponse {
63-
// Actual MIME type of response
64-
string mime_type = 1;
65-
// Frame in bytes
66-
bytes image = 2;
67-
}
68-
6941
message GetImagesRequest {
7042
// Name of a camera
7143
string name = 1;
@@ -86,22 +58,13 @@ message GetImagesResponse {
8658
message Image {
8759
// the name of the sensor where the image came from
8860
string source_name = 1;
89-
// format of the response image bytes
90-
Format format = 2;
61+
reserved 2; // previously use for Format, reserving as per https://protobuf.dev/programming-guides/proto3/#deleting
9162
// image in bytes
9263
bytes image = 3;
9364
// The mime type of the image
9465
string mime_type = 4;
9566
}
9667

97-
enum Format {
98-
FORMAT_UNSPECIFIED = 0;
99-
FORMAT_RAW_RGBA = 1;
100-
FORMAT_RAW_DEPTH = 2;
101-
FORMAT_JPEG = 3;
102-
FORMAT_PNG = 4;
103-
}
104-
10568
message RenderFrameRequest {
10669
// Name of a camera
10770
string name = 1;

0 commit comments

Comments
 (0)