DATA-4448: Remove UpdateDataPipeline from CLI/SDK (#5201)

Author: Emerald-Z

app/data_client.go

@@ -1396,26 +1396,6 @@ func (d *DataClient) CreateDataPipeline(
 	return resp.Id, nil
 }
 
-// UpdateDataPipeline updates a data pipeline configuration by its ID.
-func (d *DataClient) UpdateDataPipeline(
-	ctx context.Context, id, name string, query []map[string]interface{}, schedule string, dataSourceType TabularDataSourceType,
-) error {
-	mqlBinary, err := queryBSONToBinary(query)
-	if err != nil {
-		return err
-	}
-
-	dataSourceTypeProto := dataSourceTypeToProto(dataSourceType)
-	_, err = d.datapipelinesClient.UpdateDataPipeline(ctx, &datapipelinesPb.UpdateDataPipelineRequest{
-		Id:             id,
-		Name:           name,
-		MqlBinary:      mqlBinary,
-		Schedule:       schedule,
-		DataSourceType: &dataSourceTypeProto,
-	})
-	return err
-}
-
 // DeleteDataPipeline deletes a data pipeline by its ID.
 func (d *DataClient) DeleteDataPipeline(ctx context.Context, id string) error {
 	_, err := d.datapipelinesClient.DeleteDataPipeline(ctx, &datapipelinesPb.DeleteDataPipelineRequest{

app/data_client_test.go

@@ -1158,21 +1158,6 @@ func TestDataPipelineClient(t *testing.T) {
 		test.That(t, resp, test.ShouldEqual, "new-data-pipeline-id")
 	})
 
-	t.Run("UpdateDataPipeline", func(t *testing.T) {
-		grpcClient.UpdateDataPipelineFunc = func(
-			ctx context.Context, in *datapipelinesPb.UpdateDataPipelineRequest, opts ...grpc.CallOption,
-		) (*datapipelinesPb.UpdateDataPipelineResponse, error) {
-			test.That(t, in.Id, test.ShouldEqual, dataPipelineID)
-			test.That(t, in.Name, test.ShouldEqual, name)
-			test.That(t, in.MqlBinary, test.ShouldResemble, mqlBinary)
-			test.That(t, in.Schedule, test.ShouldEqual, "0 7 * * *")
-			test.That(t, *in.DataSourceType, test.ShouldEqual, pb.TabularDataSourceType_TABULAR_DATA_SOURCE_TYPE_STANDARD)
-			return &datapipelinesPb.UpdateDataPipelineResponse{}, nil
-		}
-		err := client.UpdateDataPipeline(context.Background(), dataPipelineID, name, mqlQueries, "0 7 * * *", TabularDataSourceTypeStandard)
-		test.That(t, err, test.ShouldBeNil)
-	})
-
 	t.Run("DeleteDataPipeline", func(t *testing.T) {
 		grpcClient.DeleteDataPipelineFunc = func(
 			ctx context.Context, in *datapipelinesPb.DeleteDataPipelineRequest, opts ...grpc.CallOption,

cli/app.go

@@ -1676,48 +1676,6 @@ var app = &cli.App{
 					},
 					Action: createCommandWithT[datapipelineCreateArgs](DatapipelineCreateAction),
 				},
-				{
-					Name:  "update",
-					Usage: "update a data pipeline",
-					UsageText: createUsageText("datapipelines update",
-						[]string{generalFlagID, generalFlagName, datapipelineFlagSchedule}, false, false,
-						fmt.Sprintf("[--%s=<%s> | --%s=<%s>]",
-							datapipelineFlagMQL, datapipelineFlagMQL,
-							datapipelineFlagMQLFile, datapipelineFlagMQLFile),
-					),
-					Flags: []cli.Flag{
-						&cli.StringFlag{
-							Name:     generalFlagID,
-							Usage:    "ID of the data pipeline to update",
-							Required: true,
-						},
-						&cli.StringFlag{
-							Name:  generalFlagName,
-							Usage: "name of the data pipeline to update",
-						},
-						&cli.StringFlag{
-							Name:  datapipelineFlagSchedule,
-							Usage: "schedule of the data pipeline to update (cron expression)",
-						},
-						&cli.StringFlag{
-							Name:  datapipelineFlagMQL,
-							Usage: "MQL query for the data pipeline to update",
-						},
-						&cli.StringFlag{
-							Name:  datapipelineFlagMQLFile,
-							Usage: "path to JSON file containing MQL query for the data pipeline to update",
-						},
-						&cli.StringFlag{
-							Name: datapipelineFlagDataSourceType,
-							Usage: formatAcceptedValues(
-								"data source type for the data pipeline to update",
-								StandardDataSourceType,
-								HotStorageDataSourceType,
-							),
-						},
-					},
-					Action: createCommandWithT[datapipelineUpdateArgs](DatapipelineUpdateAction),
-				},
 				{
 					Name:      "delete",
 					Usage:     "delete a data pipeline",

cli/datapipelines.go

@@ -112,71 +112,6 @@ func DatapipelineCreateAction(c *cli.Context, args datapipelineCreateArgs) error
 	return nil
 }
 
-type datapipelineUpdateArgs struct {
-	ID             string
-	Name           string
-	Schedule       string
-	MQL            string
-	MqlPath        string
-	DataSourceType string
-}
-
-// DatapipelineUpdateAction updates an existing data pipeline.
-func DatapipelineUpdateAction(c *cli.Context, args datapipelineUpdateArgs) error {
-	client, err := newViamClient(c)
-	if err != nil {
-		return err
-	}
-
-	resp, err := client.datapipelinesClient.GetDataPipeline(context.Background(), &datapipelinespb.GetDataPipelineRequest{
-		Id: args.ID,
-	})
-	if err != nil {
-		return fmt.Errorf("error getting data pipeline: %w", err)
-	}
-	current := resp.GetDataPipeline()
-
-	name := args.Name
-	if name == "" {
-		name = current.GetName()
-	}
-
-	schedule := args.Schedule
-	if schedule == "" {
-		schedule = current.GetSchedule()
-	}
-
-	mqlBinary := current.GetMqlBinary()
-	if args.MQL != "" || args.MqlPath != "" {
-		mqlBinary, err = parseMQL(args.MQL, args.MqlPath)
-		if err != nil {
-			return err
-		}
-	}
-
-	dataSourceType := current.GetDataSourceType()
-	if args.DataSourceType != "" {
-		dataSourceType, err = dataSourceTypeToProto(args.DataSourceType)
-		if err != nil {
-			return err
-		}
-	}
-
-	_, err = client.datapipelinesClient.UpdateDataPipeline(context.Background(), &datapipelinespb.UpdateDataPipelineRequest{
-		Id:             args.ID,
-		Name:           name,
-		Schedule:       schedule,
-		MqlBinary:      mqlBinary,
-		DataSourceType: &dataSourceType,
-	})
-	if err != nil {
-		return fmt.Errorf("error updating data pipeline: %w", err)
-	}
-
-	printf(c.App.Writer, "%s (id: %s) updated.", name, args.ID)
-	return nil
-}
-
 type datapipelineDeleteArgs struct {
 	ID string
 }