RSDK-12341 Add fake audio component models #5538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
seanavery
approved these changes
Nov 25, 2025
|
|
||
| a := &AudioIn{ | ||
| Named: conf.ResourceName().AsNamed(), | ||
| Geometry: []spatialmath.Geometry{}, |
Member
There was a problem hiding this comment.
Not related to this PR, but why does AudioIn need a Geometry?
Member
Author
There was a problem hiding this comment.
every API has a getGeometry function so i added one to audio for consistency, it probably wouldn't ever be used tho
viambot
removed
the
safe to test
viambot
added
the
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fake audio in and out components, tested functions with go client script.