Smoke-test dispatch failed for 0.3.1-rc10

[vig-os-release-app]

Smoke-test dispatch failed while orchestrating downstream release validation.

Dispatch metadata

• tag: 0.3.1-rc10
• release_kind: candidate
• source_repo: vig-os/devcontainer
• source_workflow: Release
• source_run_id: 23400039119
• source_run_url: https://github.com/vig-os/devcontainer/actions/runs/23400039119
• source_sha: 60ae67a84619b17dd61e0c229217a4ed2ddb164b
• correlation_id: vig-os/devcontainer:23400039119:0.3.1-rc10

Workflow context

• downstream workflow run: https://github.com/vig-os/devcontainer-smoke-test/actions/runs/23400308501
• deploy PR: chore: deploy 0.3.1-rc10 devcontainer-smoke-test#57
• release PR: chore: release 0.3.1 devcontainer-smoke-test#58

Job results

• validate: success
• deploy: success
• wait-deploy-merge: success
• cleanup-release: success
• trigger-prepare-release: success
• ready-release-pr: failure
• trigger-release: skipped
• summary: failure

Manual cleanup guidance

• Inspect deploy/release PRs and workflow logs before retrying.
• If needed, close stale release PRs and delete stale release/<version> branch.
• Re-dispatch using a new RC tag/version once root cause is fixed.

[c-vigo]

Root Cause Analysis

Cause: Self-approval by the same GitHub App that authored the PR.

The repository-dispatch.yml on main in devcontainer-smoke-test runs an
outdated version of the ready-release-pr job that calls
gh pr review --approve after creating the release PR. Since the same app
(vig-os-release-app[bot]) authored PR #58 and attempted to approve it,
GitHub rejected with:

failed to create review: GraphQL: Review Can not approve your own pull request

This caused the ready-release-pr job to fail, which cascaded: auto-merge was
never enabled, release-kind labels were never applied, and trigger-release was
skipped entirely.

Why the old workflow ran: repository_dispatch events always use the
workflow from the default branch (main). The fix was already deployed to dev
via 0.3.1-rc10, but hasn't reached main yet -- a bootstrap problem since
the release PR merge is what promotes it.

Evidence:

• Failing step log -- step "Mark release PR ready and approve", error at gh pr review --approve
• PR #58 -- open, CLEAN merge state, auto-merge not enabled, no labels

Current state of PR #58:

• Open, ready for review, mergeable (CLEAN)
• Auto-merge: not enabled
• Contains the corrected workflow (no self-approve)

Resolution: Manually merge PR #58. This promotes the fixed workflow to
main, preventing recurrence for future dispatches. No upstream code changes
needed -- the template already has the fix.

[c-vigo]

Follow-up

PR #58 has been merged to main in devcontainer-smoke-test.

The updated repository-dispatch.yml (no self-approve; label + auto-merge steps) is now the default-branch workflow, so future repository_dispatch runs should no longer hit the failure described in the RCA.

Closing as resolved.