CriticMarkup not working inside some highlighting elements

[thriveth]

Best way to illustrate the issue is by this screenshot:

I don't know if this is a vim-pandoc or a vim-criticmarkup issue, so I'm posting it here.

[fmoralesc]

It was a problem here. Just pushed a fix to master.

[thriveth]

I don't know if this is a feature or a bug, but it also does not work inside YAML blocks, like e.g. the abstract.

[fmoralesc]

I'll call that "undefined behavior"... Just pushed a fix to master.

[fmoralesc]

Feel free to tell me if it doesn't work with other stuff. I'll reopen the issue just in case.

[thriveth]

I just updated, and it is indeed fixed in definition lists, but still not working in YAML front matter block (specifically abstract).

[fmoralesc]

Can you tell me what is the output of

:echo synIDattr(synID(line('.'), col('.'), 1), "name")

when the cursor is in the text that needs to be highlighted?

[thriveth]

Yes, that is yamlPlainScalar. If I enclose it in quotes (which for other reasons is a bad idea for a multiline string in YAML), the result is yamlFlowString.

[fmoralesc]

Thanks, I pushed the required change to master.

[thriveth]

That seems to have broken something. It works partially, but breaks subsequent parsing of the Pandoc file:

If I remove the CM tags, it works fine:

[fmoralesc]

I think it's an issue with the YAML syntax, with a small tweak (now in master) I have this:

What YAML syntax file are you using? I'm using this one

[thriveth]

I use whatever vim-pandoc uses.
Here's what it looks like here after the latest update.

Observation: After having inserted some more CM here, the highlight got messed up further down the pandoc MD document, but only until I ran the cursor down through the lines. This didn't happen before.

[thriveth]

Also: If I enclose the string in quotes, the weirdness seems to go away.

[thenerdlawyer]

I'm having this issue as well. Numbered lists fail when filetype=pandoc, but not when filetype=markdown.
Criticmarkup shows up fine in normal text regardless of filetype.

Numbered & bulleted lists and block quotes look like this when filetype=markdown:

But like this when filetype=pandoc: