Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are comments and highlights not handled? #9

Open
bpj opened this issue Jul 12, 2016 · 2 comments
Open

Why are comments and highlights not handled? #9

bpj opened this issue Jul 12, 2016 · 2 comments

Comments

@bpj
Copy link

bpj commented Jul 12, 2016

Is there some deep reason why comments and highlights aren't handled, or is it just because nobody has done it yet?

If it's just the latter, do you mind if I have a shot at it?

Admittedly accept and reject don't seem to be the right terms there; remove, uncomment, unhi(gh)light comes to mind.

@fmoralesc
Copy link
Member

What do you mean by "are not handled"? Do the highlights don't show up? Is there some extra functionality you need?

To be fair, I haven't had much time to check the status of the plugin, so if you have a problem and are able to figure it out, I would appreciate any help ;)

@bpj
Copy link
Author

bpj commented Jul 12, 2016

I mean as per the TODO section in the readme:

TODO

  • Expand accepts and rejects to handle highlights and comments.
  • Implement operators and keyboard mappings to create annotations.

BTW I have kind-of solutiions to the second point using the surround and UltiSnips plugins.
They could be mentioned in the readme of this plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants