Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn FileLeafSkel.derived into JsonBone #1306

Open
phorward opened this issue Oct 29, 2024 · 0 comments
Open

Turn FileLeafSkel.derived into JsonBone #1306

phorward opened this issue Oct 29, 2024 · 0 comments
Assignees
@bb-mausbrand
Labels
proposal refactoring Pull requests that refactor code but do not change its behavior.

Comments

@phorward
Copy link
Member

phorward commented Oct 29, 2024 •
edited by sveneberth
Loading

Again, ViUR-core doesn't make use of its own capabilities.

viur-core/src/viur/core/modules/file.py

Line 344 in e33f1d9

derived = BaseBone(
is currently a BaseBone, but contains an object. There should be a (validated) JsonBone used for that.
@phorward phorward added proposal refactoring Pull requests that refactor code but do not change its behavior. labels Oct 29, 2024
@phorward phorward added this to the ViUR-core v3.8 milestone Oct 29, 2024
@phorward phorward removed this from the ViUR-core v3.8 milestone Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bb-mausbrand bb-mausbrand

Labels
proposal refactoring Pull requests that refactor code but do not change its behavior.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phorward @bb-mausbrand