-
Notifications
You must be signed in to change notification settings - Fork 513
🐛 [Bug] Glitched models for partybots #2996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The character is displayed by the client. After test: #2996 (comment) |
Hi, do you know what should I do to try to fix that? Please note that I tried 3 different clients, made fresh installations. I used some random client, elysium client and mine that I had for years. Do you know client that I could test? |
Is this specific to a race? Or does it happen with all races? |
I have noticed it only on tauren if I remember well...like horns missing, low poly faces and so on |
Looks like a serverside bug to me. Female taureens seem to be affected. https://github.com/vmangos/core/blob/development/src/game/PlayerBots/PlayerBotAI.cpp#L81-L86 |
It happens with male models too. |
Good way to test it is to create undead character and summon full raid of shamans, then take a look at them and you will see some are glitched. |
Okay, I'll check it out now. Maybe we don't pay attention to it. |
I got a problem, try changing the code here like this: https://github.com/vmangos/core/blob/development/src/game/PlayerBots/PlayerBotAI.cpp#L81-L86 uint8 gender;
uint8 skin;
uint8 face;
uint8 hairStyle;
uint8 hairColor;
uint8 facialHair;
do
{
gender = pClone ? pClone->GetByteValue(UNIT_FIELD_BYTES_0, UNIT_BYTES_0_OFFSET_GENDER) : urand(0, 1);
skin = pClone ? pClone->GetByteValue(PLAYER_BYTES, PLAYER_BYTES_OFFSET_SKIN_ID) : urand(0, 5);
face = pClone ? pClone->GetByteValue(PLAYER_BYTES, PLAYER_BYTES_OFFSET_FACE_ID) : urand(0, 5);
hairStyle = pClone ? pClone->GetByteValue(PLAYER_BYTES, PLAYER_BYTES_OFFSET_HAIR_STYLE_ID) : urand(0, 5);
hairColor = pClone ? pClone->GetByteValue(PLAYER_BYTES, PLAYER_BYTES_OFFSET_HAIR_COLOR_ID) : urand(0, 5);
facialHair = pClone ? pClone->GetByteValue(PLAYER_BYTES_2, PLAYER_BYTES_2_OFFSET_FACIAL_STYLE) : urand(0, 5);
}
while (!Player::ValidateAppearance(race_, class_, gender, hairStyle, hairColor, face, facialHair, skin, true)); This should help. I checked it out. |
@mserajnik Maybe you'll do pr? |
@gajet5 Wait, why me? 😮 |
You're in my bookmarks :) |
I'm honored, but I didn't take part in this discussion at all, so maybe it would be better if you or maybe @Gamemechanicwow (if you don't want to create a fork) opened a PR for this seeing how you already did the research too. 😆 |
Sorry to ask but when will it be solved? I literally don't understand. |
|
Man I hardly managed to compile for the first time, I thought somebody has to change it in core si it automatically gets fixed on update. |
I'll take a look at it tomorrow, don't worry about it for now. |
🐛 Bug report
I am using brotalnia repack v24 but have noticed this on earlier versions. When I use .partybot commands to add bots sometimes (I would say 1 in 10 chance) bots appear with glitched faces, very low poly, eyes missing etc. I know it is not major but I wanted to report it.
guid: 114 - was a good example of this problem.
Tested this problem with few different fresh clients and with fresh repacks, problem always appeared.
Client Version:
Operating System:
The text was updated successfully, but these errors were encountered: