Skip to content

🐛 [Bug] Glitched models for partybots #2996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
patrikv13 opened this issue Apr 2, 2025 · 17 comments · May be fixed by #3010
Open

🐛 [Bug] Glitched models for partybots #2996

patrikv13 opened this issue Apr 2, 2025 · 17 comments · May be fixed by #3010
Labels
bug Something isn't working

Comments

@patrikv13
Copy link

🐛 Bug report

I am using brotalnia repack v24 but have noticed this on earlier versions. When I use .partybot commands to add bots sometimes (I would say 1 in 10 chance) bots appear with glitched faces, very low poly, eyes missing etc. I know it is not major but I wanted to report it.

guid: 114 - was a good example of this problem.

Tested this problem with few different fresh clients and with fresh repacks, problem always appeared.

Client Version:

  • 1.12.1.5875

Operating System:

  • Win 11 Pro
@patrikv13 patrikv13 added the bug Something isn't working label Apr 2, 2025
@gajet5
Copy link
Contributor

gajet5 commented Apr 3, 2025

The character is displayed by the client.
Not a server.
You may have a problem with the PC components. There are not enough resources for the server and client.

After test: #2996 (comment)

@patrikv13
Copy link
Author

Hi, do you know what should I do to try to fix that? Please note that I tried 3 different clients, made fresh installations. I used some random client, elysium client and mine that I had for years. Do you know client that I could test?

@Gamemechanicwow
Copy link
Contributor

Is this specific to a race? Or does it happen with all races?

@patrikv13
Copy link
Author

I have noticed it only on tauren if I remember well...like horns missing, low poly faces and so on

@Gamemechanicwow
Copy link
Contributor

Looks like a serverside bug to me. Female taureens seem to be affected.
Imo we either need to validate the appearance of generated bots or maybe set a stricter upperlimit on randomness.

https://github.com/vmangos/core/blob/development/src/game/PlayerBots/PlayerBotAI.cpp#L81-L86

@patrikv13
Copy link
Author

It happens with male models too.

@patrikv13
Copy link
Author

Good way to test it is to create undead character and summon full raid of shamans, then take a look at them and you will see some are glitched.

@gajet5
Copy link
Contributor

gajet5 commented Apr 7, 2025

Good way to test it is to create undead character and summon full raid of shamans, then take a look at them and you will see some are glitched.

Okay, I'll check it out now. Maybe we don't pay attention to it.

@gajet5
Copy link
Contributor

gajet5 commented Apr 7, 2025

Good way to test it is to create undead character and summon full raid of shamans, then take a look at them and you will see some are glitched.

I got a problem, try changing the code here like this:
Image

https://github.com/vmangos/core/blob/development/src/game/PlayerBots/PlayerBotAI.cpp#L81-L86

    uint8 gender;
    uint8 skin;
    uint8 face;
    uint8 hairStyle;
    uint8 hairColor;
    uint8 facialHair;

    do
    {
        gender = pClone ? pClone->GetByteValue(UNIT_FIELD_BYTES_0, UNIT_BYTES_0_OFFSET_GENDER) : urand(0, 1);
        skin = pClone ? pClone->GetByteValue(PLAYER_BYTES, PLAYER_BYTES_OFFSET_SKIN_ID) : urand(0, 5);
        face = pClone ? pClone->GetByteValue(PLAYER_BYTES, PLAYER_BYTES_OFFSET_FACE_ID) : urand(0, 5);
        hairStyle = pClone ? pClone->GetByteValue(PLAYER_BYTES, PLAYER_BYTES_OFFSET_HAIR_STYLE_ID) : urand(0, 5);
        hairColor = pClone ? pClone->GetByteValue(PLAYER_BYTES, PLAYER_BYTES_OFFSET_HAIR_COLOR_ID) : urand(0, 5);
        facialHair = pClone ? pClone->GetByteValue(PLAYER_BYTES_2, PLAYER_BYTES_2_OFFSET_FACIAL_STYLE) : urand(0, 5);
    }
    while (!Player::ValidateAppearance(race_, class_, gender, hairStyle, hairColor, face, facialHair, skin, true));

This should help. I checked it out.

@gajet5
Copy link
Contributor

gajet5 commented Apr 7, 2025

@mserajnik Maybe you'll do pr?

@mserajnik
Copy link
Contributor

@gajet5 Wait, why me? 😮

@gajet5
Copy link
Contributor

gajet5 commented Apr 7, 2025

@gajet5 Wait, why me? 😮

You're in my bookmarks :)
You already have a fork, but I don't, or you want me to create a fork again :)

@mserajnik
Copy link
Contributor

You're in my bookmarks :) You already have a fork, but I don't, or you want me to create a fork again :)

I'm honored, but I didn't take part in this discussion at all, so maybe it would be better if you or maybe @Gamemechanicwow (if you don't want to create a fork) opened a PR for this seeing how you already did the research too. 😆

@patrikv13
Copy link
Author

Sorry to ask but when will it be solved? I literally don't understand.

@gajet5
Copy link
Contributor

gajet5 commented Apr 14, 2025

Sorry to ask but when will it be solved? I literally don't understand.

#2996 (comment)

@patrikv13
Copy link
Author

Man I hardly managed to compile for the first time, I thought somebody has to change it in core si it automatically gets fixed on update.

@Wall-core
Copy link
Contributor

I'll take a look at it tomorrow, don't worry about it for now.

gajet5 added a commit to gajet5/core that referenced this issue Apr 15, 2025
@gajet5 gajet5 linked a pull request Apr 15, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants