Revert "Malformed CIDs do not pass URL validation of nginx."

vmcj · vmcj · commit 2f928635d108 · 2022-01-24T13:51:28.000+01:00
This reverts commit 33a5dff.
diff --git a/webapp/src/Controller/API/AwardsController.php b/webapp/src/Controller/API/AwardsController.php
@@ -25,7 +25,6 @@
  * @OA\Parameter(ref="#/components/parameters/cid")
  * @OA\Response(response="404", ref="#/components/responses/NotFound")
  * @OA\Response(response="401", ref="#/components/responses/Unauthorized")
- * @OA\Response(response="400", ref="#/components/responses/InvalidResponse")
  */
 class AwardsController extends AbstractRestController
 {
diff --git a/webapp/src/Controller/API/BalloonController.php b/webapp/src/Controller/API/BalloonController.php
@@ -19,7 +19,6 @@
  * @OA\Parameter(ref="#/components/parameters/cid")
  * @OA\Response(response="404", ref="#/components/responses/NotFound")
  * @OA\Response(response="401", ref="#/components/responses/Unauthorized")
- * @OA\Response(response="400", ref="#/components/responses/InvalidResponse")
  * @Security("is_granted('ROLE_JURY') or is_granted('ROLE_API_READER') or is_granted('ROLE_BALLOON')")
  */
 class BalloonController extends AbstractRestController
diff --git a/webapp/src/Controller/API/ClarificationController.php b/webapp/src/Controller/API/ClarificationController.php
@@ -25,7 +25,6 @@
  * @OA\Parameter(ref="#/components/parameters/cid")
  * @OA\Response(response="404", ref="#/components/responses/NotFound")
  * @OA\Response(response="401", ref="#/components/responses/Unauthorized")
- * @OA\Response(response="400", ref="#/components/responses/InvalidResponse")
  */
 class ClarificationController extends AbstractRestController
 {
diff --git a/webapp/src/Controller/API/ContestController.php b/webapp/src/Controller/API/ContestController.php
@@ -41,7 +41,6 @@
  * @OA\Tag(name="Contests")
  * @OA\Response(response="404", ref="#/components/responses/NotFound")
  * @OA\Response(response="401", ref="#/components/responses/Unauthorized")
- * @OA\Response(response="400", ref="#/components/responses/InvalidResponse")
  */
 class ContestController extends AbstractRestController
 {
@@ -333,6 +332,10 @@ public function setBannerAction(Request $request, string $id, ValidatorInterface
      *     description="Contest start time changed successfully",
      * )
      * @OA\Response(
+     *     response="400",
+     *     description="Invalid input data"
+     * )
+     * @OA\Response(
      *     response="403",
      *     description="Changing start time not allowed"
      * )
diff --git a/webapp/src/Controller/API/GeneralInfoController.php b/webapp/src/Controller/API/GeneralInfoController.php
@@ -29,7 +29,6 @@
 
 /**
  * @OA\Tag(name="General")
- * @OA\Response(response="400", ref="#/components/responses/InvalidResponse")
  */
 class GeneralInfoController extends AbstractFOSRestController
 {
diff --git a/webapp/src/Controller/API/GroupController.php b/webapp/src/Controller/API/GroupController.php
@@ -22,7 +22,6 @@
  * @OA\Parameter(ref="#/components/parameters/cid")
  * @OA\Response(response="404", ref="#/components/responses/NotFound")
  * @OA\Response(response="401", ref="#/components/responses/Unauthorized")
- * @OA\Response(response="400", ref="#/components/responses/InvalidResponse")
  */
 class GroupController extends AbstractRestController
 {
diff --git a/webapp/src/Controller/API/JudgehostController.php b/webapp/src/Controller/API/JudgehostController.php
@@ -50,7 +50,6 @@
 /**
  * @Rest\Route("/judgehosts")
  * @OA\Tag(name="Judgehosts")
- * @OA\Response(response="400", ref="#/components/responses/InvalidResponse")
  */
 class JudgehostController extends AbstractFOSRestController
 {
diff --git a/webapp/src/Controller/API/JudgementController.php b/webapp/src/Controller/API/JudgementController.php
@@ -25,7 +25,6 @@
  * @OA\Parameter(ref="#/components/parameters/cid")
  * @OA\Response(response="404", ref="#/components/responses/NotFound")
  * @OA\Response(response="401", ref="#/components/responses/Unauthorized")
- * @OA\Response(response="400", ref="#/components/responses/InvalidResponse")
  */
 class JudgementController extends AbstractRestController implements QueryObjectTransformer
 {
diff --git a/webapp/src/Controller/API/JudgementTypeController.php b/webapp/src/Controller/API/JudgementTypeController.php
@@ -15,7 +15,6 @@
 /**
  * @Rest\Route("/contests/{cid}/judgement-types")
  * @OA\Tag(name="Judgement types")
- * @OA\Response(response="400", ref="#/components/responses/InvalidResponse")
  */
 class JudgementTypeController extends AbstractRestController
 {
diff --git a/webapp/src/Controller/API/LanguageController.php b/webapp/src/Controller/API/LanguageController.php
@@ -18,7 +18,6 @@
  * @OA\Parameter(ref="#/components/parameters/cid")
  * @OA\Response(response="404", ref="#/components/responses/NotFound")
  * @OA\Response(response="401", ref="#/components/responses/Unauthorized")
- * @OA\Response(response="400", ref="#/components/responses/InvalidResponse")
  */
 class LanguageController extends AbstractRestController
 {
diff --git a/webapp/src/Controller/API/OrganizationController.php b/webapp/src/Controller/API/OrganizationController.php
@@ -34,7 +34,6 @@
  * @OA\Parameter(ref="#/components/parameters/cid")
  * @OA\Response(response="404", ref="#/components/responses/NotFound")
  * @OA\Response(response="401", ref="#/components/responses/Unauthorized")
- * @OA\Response(response="400", ref="#/components/responses/InvalidResponse")
  */
 class OrganizationController extends AbstractRestController
 {
diff --git a/webapp/src/Controller/API/ProblemController.php b/webapp/src/Controller/API/ProblemController.php
@@ -32,7 +32,6 @@
  * @OA\Parameter(ref="#/components/parameters/cid")
  * @OA\Response(response="404", ref="#/components/responses/NotFound")
  * @OA\Response(response="401", ref="#/components/responses/Unauthorized")
- * @OA\Response(response="400", ref="#/components/responses/InvalidResponse")
  */
 class ProblemController extends AbstractRestController implements QueryObjectTransformer
 {
diff --git a/webapp/src/Controller/API/RunController.php b/webapp/src/Controller/API/RunController.php
@@ -25,7 +25,6 @@
  * @OA\Parameter(ref="#/components/parameters/cid")
  * @OA\Response(response="404", ref="#/components/responses/NotFound")
  * @OA\Response(response="401", ref="#/components/responses/Unauthorized")
- * @OA\Response(response="400", ref="#/components/responses/InvalidResponse")
  */
 class RunController extends AbstractRestController implements QueryObjectTransformer
 {
diff --git a/webapp/src/Controller/API/ScoreboardController.php b/webapp/src/Controller/API/ScoreboardController.php
@@ -28,7 +28,6 @@
  * @OA\Parameter(ref="#/components/parameters/cid")
  * @OA\Response(response="404", ref="#/components/responses/NotFound")
  * @OA\Response(response="401", ref="#/components/responses/Unauthorized")
- * @OA\Response(response="400", ref="#/components/responses/InvalidResponse")
  */
 class ScoreboardController extends AbstractRestController
 {
diff --git a/webapp/src/Controller/API/SubmissionController.php b/webapp/src/Controller/API/SubmissionController.php
@@ -38,7 +38,6 @@
  * @OA\Parameter(ref="#/components/parameters/cid")
  * @OA\Response(response="404", ref="#/components/responses/NotFound")
  * @OA\Response(response="401", ref="#/components/responses/Unauthorized")
- * @OA\Response(response="400", ref="#/components/responses/InvalidResponse")
  */
 class SubmissionController extends AbstractRestController
 {
diff --git a/webapp/src/Controller/API/TeamController.php b/webapp/src/Controller/API/TeamController.php
@@ -33,7 +33,6 @@
  * @OA\Parameter(ref="#/components/parameters/cid")
  * @OA\Response(response="404", ref="#/components/responses/NotFound")
  * @OA\Response(response="401", ref="#/components/responses/Unauthorized")
- * @OA\Response(response="400", ref="#/components/responses/InvalidResponse")
  */
 class TeamController extends AbstractRestController
 {
diff --git a/webapp/src/Controller/API/UserController.php b/webapp/src/Controller/API/UserController.php
@@ -28,7 +28,6 @@
  * @OA\Tag(name="Users")
  * @OA\Response(response="404", ref="#/components/responses/NotFound")
  * @OA\Response(response="401", ref="#/components/responses/Unauthorized")
- * @OA\Response(response="400", ref="#/components/responses/InvalidResponse")
  */
 class UserController extends AbstractRestController
 {

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,6 @@`
`25`	`25`	`* @OA\Parameter(ref="#/components/parameters/cid")`
`26`	`26`	`* @OA\Response(response="404", ref="#/components/responses/NotFound")`
`27`	`27`	`* @OA\Response(response="401", ref="#/components/responses/Unauthorized")`
`28`		`- * @OA\Response(response="400", ref="#/components/responses/InvalidResponse")`
`29`	`28`	`*/`
`30`	`29`	`class AwardsController extends AbstractRestController`
`31`	`30`	`{`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,6 @@`
`29`	`29`
`30`	`30`	`/**`
`31`	`31`	`* @OA\Tag(name="General")`
`32`		`- * @OA\Response(response="400", ref="#/components/responses/InvalidResponse")`
`33`	`32`	`*/`
`34`	`33`	`class GeneralInfoController extends AbstractFOSRestController`
`35`	`34`	`{`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,6 @@`
`22`	`22`	`* @OA\Parameter(ref="#/components/parameters/cid")`
`23`	`23`	`* @OA\Response(response="404", ref="#/components/responses/NotFound")`
`24`	`24`	`* @OA\Response(response="401", ref="#/components/responses/Unauthorized")`
`25`		`- * @OA\Response(response="400", ref="#/components/responses/InvalidResponse")`
`26`	`25`	`*/`
`27`	`26`	`class GroupController extends AbstractRestController`
`28`	`27`	`{`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,6 @@`
`50`	`50`	`/**`
`51`	`51`	`* @Rest\Route("/judgehosts")`
`52`	`52`	`* @OA\Tag(name="Judgehosts")`
`53`		`- * @OA\Response(response="400", ref="#/components/responses/InvalidResponse")`
`54`	`53`	`*/`
`55`	`54`	`class JudgehostController extends AbstractFOSRestController`
`56`	`55`	`{`
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,6 @@`
`15`	`15`	`/**`
`16`	`16`	`* @Rest\Route("/contests/{cid}/judgement-types")`
`17`	`17`	`* @OA\Tag(name="Judgement types")`
`18`		`- * @OA\Response(response="400", ref="#/components/responses/InvalidResponse")`
`19`	`18`	`*/`
`20`	`19`	`class JudgementTypeController extends AbstractRestController`
`21`	`20`	`{`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,6 @@`
`18`	`18`	`* @OA\Parameter(ref="#/components/parameters/cid")`
`19`	`19`	`* @OA\Response(response="404", ref="#/components/responses/NotFound")`
`20`	`20`	`* @OA\Response(response="401", ref="#/components/responses/Unauthorized")`
`21`		`- * @OA\Response(response="400", ref="#/components/responses/InvalidResponse")`
`22`	`21`	`*/`
`23`	`22`	`class LanguageController extends AbstractRestController`
`24`	`23`	`{`