Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure and version hints file #83

Open
migmartri opened this issue Nov 15, 2021 · 2 comments
Open

Structure and version hints file #83

migmartri opened this issue Nov 15, 2021 · 2 comments

Comments

@migmartri
Copy link
Contributor

Currently, the hints file format is a flat list of images. That does not leave any room for additional metadata such as the version of the schema/templating mechanism used.

Having the possibility of indicating the version of the file format is important since it's likely this file format might evolve in the future

My proposal is to change the schema to

message hintsFile {
  string version = 1; // optional, we can assume for now that's v1
  repeated string images = 2  
}

In practice this means that images need to be inside a :images property

So a hints file would go from

- "{{ .image.registry }}/{{ .image.repository }}:{{ .image.tag }}"
- "{{ .metrics.image.registry }}/{{ .metrics.image.repository }}:{{ .metrics.image.tag }}"
- "{{ .volumePermissions.image.registry }}/{{ .volumePermissions.image.repository }}:{{ .volumePermissions.image.tag }}"

to

images:
  - "{{ .image.registry }}/{{ .image.repository }}:{{ .image.tag }}"
  - "{{ .metrics.image.registry }}/{{ .metrics.image.repository }}:{{ .metrics.image.tag }}"
  - "{{ .volumePermissions.image.registry }}/{{ .volumePermissions.image.repository }}:{{ .volumePermissions.image.tag }}"

The implementation of the new format should be retro-compatible with the current one.

What do you think?

cc/ @tompizmor @josvazg @petewall

@petewall
Copy link
Contributor

This is a good idea.

@josvazg
Copy link
Contributor

josvazg commented Dec 13, 2021

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@migmartri @josvazg @petewall and others