Skip to content

Commit 402e9f7

Browse files
committed
Resolve many breaking changes
1 parent ed6cab8 commit 402e9f7

File tree

16 files changed

+197
-322
lines changed

16 files changed

+197
-322
lines changed

PACKAGES.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,6 @@ Thank you for your continued efforts.
4949
* [github.com/stretchr/testify/require](https://github.com/stretchr/testify/require)
5050
* [github.com/unrolled/render](https://github.com/unrolled/render)
5151
* [github.com/volatiletech/sqlboiler](https://github.com/volatiletech/sqlboiler)
52-
* [github.com/volatiletech/sqlboiler/v4/bdb](https://github.com/volatiletech/sqlboiler/v4/bdb)
53-
* [github.com/volatiletech/sqlboiler/v4/bdb/drivers](https://github.com/volatiletech/sqlboiler/v4/bdb/drivers)
54-
* [github.com/volatiletech/sqlboiler/v4/strmangle](https://github.com/volatiletech/sqlboiler/v4/strmangle)
5552
* [github.com/volatiletech/abcweb/abcmiddleware](https://github.com/volatiletech/abcweb/abcmiddleware)
5653
* [github.com/volatiletech/abcweb/abcrender](https://github.com/volatiletech/abcweb/abcrender)
5754
* [github.com/volatiletech/abcweb/abcsessions](https://github.com/volatiletech/abcweb/abcsessions)

abcdatabase/database.go

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,16 @@
11
package abcdatabase
22

33
import (
4-
"bytes"
5-
"database/sql"
64
"fmt"
75
"io/ioutil"
86
"os"
9-
"os/exec"
107
"path/filepath"
118
"regexp"
129
"strconv"
10+
"strings"
1311

1412
"github.com/pkg/errors"
1513
"github.com/volatiletech/abcweb/abcconfig"
16-
"github.com/volatiletech/helpers/git"
1714
"github.com/volatiletech/mig"
1815
)
1916

@@ -60,7 +57,7 @@ func RunMigrations(cfg abcconfig.DBConfig, migrationsPath string) (int, error) {
6057
return 0, err
6158
}
6259

63-
count, err := mig.Up(cfg.DB, connStr, migrationsPath)
60+
count, err := mig.Up("postgres", connStr, migrationsPath)
6461
if err != nil {
6562
return count, err
6663
}
@@ -82,7 +79,7 @@ func IsMigrated(cfg abcconfig.DBConfig) (bool, int64, error) {
8279
return false, 0, err
8380
}
8481

85-
version, err := mig.Version(cfg.DB, connStr)
82+
version, err := mig.Version("postgres", connStr)
8683
if err != nil {
8784
return false, version, err
8885
}
@@ -112,4 +109,4 @@ func isLatestVersion(dbVersion int64, files []os.FileInfo) bool {
112109
}
113110

114111
return highestVersion == dbVersion
115-
}
112+
}

abcmiddleware/errors.go

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,16 @@ type ErrorContainer struct {
3030
Handler ErrorHandler
3131
}
3232

33-
type errorManager struct {
33+
// ErrorManager helps manage errors at the application level
34+
type ErrorManager struct {
3435
render abcrender.Renderer
3536
errors []ErrorContainer
3637
}
3738

3839
// NewErrorManager creates an error manager that can be used to
3940
// create an error handler to wrap your controllers with
40-
func NewErrorManager(render abcrender.Renderer) *errorManager {
41-
return &errorManager{
41+
func NewErrorManager(render abcrender.Renderer) *ErrorManager {
42+
return &ErrorManager{
4243
render: render,
4344
errors: []ErrorContainer{},
4445
}
@@ -67,7 +68,7 @@ func NewError(err error, code int, template string, handler ErrorHandler) ErrorC
6768
}
6869

6970
// Remove a ErrorContainer from the error manager
70-
func (m *errorManager) Remove(e ErrorContainer) {
71+
func (m *ErrorManager) Remove(e ErrorContainer) {
7172
for i, v := range m.errors {
7273
if reflect.DeepEqual(v, e) {
7374
m.errors = append(m.errors[:i], m.errors[i+1:]...)
@@ -76,7 +77,7 @@ func (m *errorManager) Remove(e ErrorContainer) {
7677
}
7778

7879
// Add a new ErrorContainer to the error manager
79-
func (m *errorManager) Add(e ErrorContainer) {
80+
func (m *ErrorManager) Add(e ErrorContainer) {
8081
m.errors = append(m.errors, e)
8182
}
8283

@@ -91,7 +92,7 @@ type ErrorHandler func(w http.ResponseWriter, r *http.Request, e ErrorContainer,
9192
// errors directly in your controller is that it's all centralized to one
9293
// location which simplifies adding notifiers (like slack and email).
9394
// It also reduces a lot of controller boilerplate.
94-
func (m *errorManager) Errors(ctrl AppHandler) http.HandlerFunc {
95+
func (m *ErrorManager) Errors(ctrl AppHandler) http.HandlerFunc {
9596
return func(w http.ResponseWriter, r *http.Request) {
9697
err := ctrl(w, r)
9798
if err == nil {

abcmiddleware/middleware.go

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,11 @@ package abcmiddleware
22

33
import (
44
"net/http"
5-
6-
"go.uber.org/zap"
75
)
86

97
// MiddlewareFunc is the function signature for Chi's Use() middleware
108
type MiddlewareFunc func(http.Handler) http.Handler
119

12-
// Middleware exposes useful variables to every abcmiddleware handler
13-
type Middleware struct {
14-
// Log is used for logging in your middleware and to
15-
// create a derived logger that includes the request ID.
16-
Log *zap.Logger
17-
}
18-
1910
// MW is an interface defining middleware wrapping
2011
type MW interface {
2112
Wrap(http.Handler) http.Handler

abcserver/routes.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ func NewNotFoundHandler(manifest map[string]string) *NotFound {
7575
func (n *NotFound) Handler(cfg abcconfig.ServerConfig, render abcrender.Renderer) http.HandlerFunc {
7676
return func(w http.ResponseWriter, r *http.Request) {
7777
// Get the Request ID scoped logger
78-
log := abcmiddleware.Log(r)
78+
log := abcmiddleware.Logger(r)
7979

8080
reqPath := r.URL.Path
8181
// Ensure path is rooted at / to prevent path traversal
@@ -168,7 +168,7 @@ func (n *NotFound) Handler(cfg abcconfig.ServerConfig, render abcrender.Renderer
168168
func (m *MethodNotAllowed) Handler(render abcrender.Renderer) http.HandlerFunc {
169169
return func(w http.ResponseWriter, r *http.Request) {
170170
// Get the Request ID scoped logger
171-
log := abcmiddleware.Log(r)
171+
log := abcmiddleware.Logger(r)
172172

173173
log.Warn("method not allowed",
174174
zap.String("method", r.Method),

cmd/config.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ type migrateConfig struct {
1919

2020
type newConfig struct {
2121
AppPath string `toml:"app-path"`
22+
TemplatePath string `toml:"template-path"`
2223
ImportPath string `toml:"import-path"`
2324
AppName string `toml:"app-name"`
2425
AppEnvName string `toml:"app-env-name"`

0 commit comments

Comments
 (0)