Misc github actions improve by hzxuzhonghu · Pull Request #1253 · volcano-sh/kthena

hzxuzhonghu · 2026-06-25T06:37:43Z

What type of PR is this?

/kind test

What this PR does / why we need it:

Make all the workflow filter run with action, so we can change the github setting to make the check a must, currently we donot have a required check for all the tests. Even test failed, a pr can be merged.
Added trigger for pull request torward release branch
removed some tests after push to main branch, we donot allow directly push.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

volcano-sh-bot · 2026-06-25T06:37:49Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hzxuzhonghu. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gemini-code-assist · 2026-06-25T06:37:57Z

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

Copilot

Pull request overview

This PR updates GitHub Actions workflows to better support release-branch pull requests and introduces a workflow-level gating pattern (via paths-filter) to avoid running E2E jobs when unrelated files change, while still producing a passing check.

Changes:

Extend multiple CI workflows to trigger on pull requests targeting release-* branches.
Update the E2E workflow to always run a lightweight “changes” job and conditionally run the E2E matrix only when relevant files changed.
Minor YAML normalization (quoting / formatting) across several workflows.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
.github/workflows/python-tests.yml	Adds release-branch PR triggering for Python tests.
.github/workflows/python-lint.yml	Adds release-branch PR triggering for Python lint.
.github/workflows/go-tests.yml	Adds release-branch PR triggering for Go unit tests; minor quoting changes.
.github/workflows/go-check.yml	Adds release-branch PR triggering for Go checks.
.github/workflows/e2e-tests.yml	Introduces `paths-filter` gating to skip E2E matrix when irrelevant, while keeping a passing workflow run.
.github/workflows/docs-tests.yml	Adds release-branch PR triggering for docs tests; minor quoting changes.
.github/workflows/codespell.yaml	Adds release-branch PR triggering for codespell.
.github/workflows/build-push-release.yml	Adds release-branch PR triggering; minor formatting/quoting changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  pull_request:
    branches:
      - main
+      - "release-**"
    paths:


  pull_request:
    branches:
      - main
+      - "release-**"
    paths-ignore:


  pull_request:
    branches:
      - main
-    paths:
-      - "pkg/**"
-      - "cmd/**"
-      - "test/**"
-      - "config/**"
-      - "charts/**"
-      - "docker/**"
-      - "hack/**"
-      - "go.mod"
-      - "go.sum"
-      - "Makefile"
-      - ".github/workflows/e2e-tests.yml"
+      - "release-**"
+


Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

    paths:
-      - '**.go'
+      - "**.go"
      - "pkg/**"
      - "cmd/**"


    paths:
-      - '**.go'
+      - "**.go"
      - "pkg/**"
      - "cmd/**"


Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

+          predicate-quantifier: every
+          filters: |
+            go_check:
+              - "**"
+              - "!**.md"
+              - "!**.svg"
+              - "!**.png"
+              - "!docs/**"
+              - "!.github/**"
+


LiZhenCheng9527 · 2026-06-29T06:12:28Z

+        with:
+          predicate-quantifier: every
+          filters: |
+            go_check:


If I modify both the Go file and these files, will this workflow be triggered?

either one matches, it will be triggered

hzxuzhonghu · 2026-06-29T06:15:17Z

/hold

Lets do this after release-1.0

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

+        with:
+          predicate-quantifier: every
+          filters: |


  build_images:
    needs: setup
    runs-on: ${{ matrix.os }}
+    permissions:
+      contents: read
+      packages: write


Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>

hzxuzhonghu · 2026-07-07T04:01:09Z

@LiZhenCheng9527 Ready to review

hzxuzhonghu · 2026-07-09T12:05:12Z

@LiZhenCheng9527

nXtCyberNet · 2026-07-09T12:49:04Z

Hi I also have a small question, currently if any user do /retest even if it's not the member in the org the e2e cycles restarted so I just want to know if it's intentional or not

Copilot AI review requested due to automatic review settings June 25, 2026 06:37

volcano-sh-bot added the kind/test label Jun 25, 2026

hzxuzhonghu assigned LiZhenCheng9527 Jun 25, 2026

volcano-sh-bot added the size/L label Jun 25, 2026

Copilot started reviewing on behalf of hzxuzhonghu June 25, 2026 06:38 View session

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings June 25, 2026 07:03

hzxuzhonghu force-pushed the workflow-improve branch from abf7873 to 10e160d Compare June 25, 2026 07:03

hzxuzhonghu added the tide/merge-method-squash label Jun 25, 2026

Copilot started reviewing on behalf of hzxuzhonghu June 25, 2026 07:03 View session

Copilot AI reviewed Jun 25, 2026

View reviewed changes

hzxuzhonghu force-pushed the workflow-improve branch from 10e160d to 97e022e Compare June 25, 2026 07:31

Copilot AI review requested due to automatic review settings June 25, 2026 08:43

Copilot started reviewing on behalf of hzxuzhonghu June 25, 2026 08:43 View session

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Comment thread .github/workflows/go-check.yml

Comment on lines +23 to +32

predicate-quantifier: every

filters: |

go_check:

- "**"

- "!**.md"

- "!**.svg"

- "!**.png"

- "!docs/**"

- "!.github/**"

Comment thread .github/workflows/licenses-lint.yaml Outdated

LiZhenCheng9527 reviewed Jun 29, 2026

View reviewed changes

volcano-sh-bot added the do-not-merge/hold label Jun 29, 2026

hzxuzhonghu force-pushed the workflow-improve branch from 6b3c5a3 to de2ebf6 Compare July 7, 2026 01:04

hzxuzhonghu requested a review from Copilot July 7, 2026 01:31

Copilot started reviewing on behalf of hzxuzhonghu July 7, 2026 01:31 View session

Copilot AI reviewed Jul 7, 2026

View reviewed changes

hzxuzhonghu added 6 commits July 7, 2026 11:56

Add trigger for release branch

0081b6f

Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>

Address comment to

502796d

Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>

Run workflow and do path filter innerly

9488d77

Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>

Update

c741998

Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>

address comment

2bc56e6

Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>

Fix build failure caused by other merged pr

7073259

Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>

hzxuzhonghu force-pushed the workflow-improve branch from de2ebf6 to 7073259 Compare July 7, 2026 04:00

hzxuzhonghu removed the do-not-merge/hold label Jul 7, 2026

Uh oh!

Conversation

hzxuzhonghu commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

volcano-sh-bot commented Jun 25, 2026

Uh oh!

gemini-code-assist Bot commented Jun 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

LiZhenCheng9527 Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

hzxuzhonghu Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

hzxuzhonghu commented Jun 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

hzxuzhonghu commented Jul 7, 2026

Uh oh!

hzxuzhonghu commented Jul 9, 2026

Uh oh!

nXtCyberNet commented Jul 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hzxuzhonghu commented Jun 25, 2026 •

edited

Loading