Skip to content

Commit c97fdcd

Browse files
committed
feat(arkitect): change endpoint_id to model_name
1 parent 075cc6b commit c97fdcd

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

arkitect/core/component/llm/base.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626

2727

2828
class BaseLanguageModel(BaseModel):
29-
endpoint_id: str
29+
model: str
3030
client: AsyncArk = Field(default_factory=default_ark_client)
3131
template: Optional[BasePromptTemplate] = None
3232
output_parser: Optional[BaseOutputParser] = None

arkitect/core/component/llm/llm.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ def generate_prompts(
7676
return format_ark_prompts(self.template, messages, **kwargs)
7777

7878
def get_request_model(self, **kwargs: Any) -> str:
79-
return self.endpoint_id
79+
return self.model
8080

8181
@task()
8282
def parse_output(self, text: str) -> Any:

tests/ut/core/component/llm/test_base_llm.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ def test_generate_prompts_with_additional_prompts() -> None:
2828
]
2929
additional_prompts = ["Welcome to the chat!", "How can I help you today?"]
3030

31-
mock_chat_model = BaseChatLanguageModel(endpoint_id="123", messages=messages)
31+
mock_chat_model = BaseChatLanguageModel(model="123", messages=messages)
3232
# Act
3333
result = mock_chat_model.generate_prompts(
3434
messages, additional_system_prompts=additional_prompts
@@ -46,7 +46,7 @@ def test_generate_prompts_without_template():
4646
ArkMessage(role="user", content="Hello"),
4747
ArkMessage(role="assistant", content="Hi there!"),
4848
]
49-
mock_chat_model = BaseChatLanguageModel(endpoint_id="123", messages=messages)
49+
mock_chat_model = BaseChatLanguageModel(model="123", messages=messages)
5050
mock_chat_model.template = None
5151

5252
# Act
@@ -63,7 +63,7 @@ def test_generate_prompts_with_formatting() -> None:
6363
ArkMessage(role="user", content="Hello"),
6464
ArkMessage(role="assistant", content="Hi there!"),
6565
]
66-
mock_chat_model = BaseChatLanguageModel(endpoint_id="123", messages=messages)
66+
mock_chat_model = BaseChatLanguageModel(model="123", messages=messages)
6767
additional_prompts = ["Welcome to the chat!", "How can I help you today?"]
6868

6969
# Act
@@ -82,7 +82,7 @@ async def test_base_chat_llm_with_unseen_tools() -> None:
8282
llm = BaseChatLanguageModel(
8383
client=MockAsyncArk(message=get_tool_call_reply()),
8484
messages=[ArkMessage(role="user", content="hi")],
85-
endpoint_id="abc",
85+
model="abc",
8686
)
8787
resp = await llm.arun()
8888
assert isinstance(resp, ArkChatResponse)
@@ -103,7 +103,7 @@ async def adder(a: int, b: int) -> int:
103103
llm = BaseChatLanguageModel(
104104
client=MockAsyncArk(message=get_tool_call_reply()),
105105
messages=[ArkMessage(role="user", content="hi")],
106-
endpoint_id="abc",
106+
model="abc",
107107
)
108108
resp = await llm.arun(functions=[adder])
109109
assert isinstance(resp, ArkChatResponse)

0 commit comments

Comments
 (0)