fix: handle initial skip all values

Author: Akryum

packages/vue-apollo/src/dollar-apollo.js

@@ -169,13 +169,15 @@ export class DollarApollo {
 
   // eslint-disable-next-line accessor-pairs
   set skipAllQueries (value) {
+    this._skipAllQueries = value
     for (const key in this.queries) {
       this.queries[key].skip = value
     }
   }
 
   // eslint-disable-next-line accessor-pairs
   set skipAllSubscriptions (value) {
+    this._skipAllSubscriptions = value
     for (const key in this.subscriptions) {
       this.subscriptions[key].skip = value
     }

packages/vue-apollo/src/smart-apollo.js

@@ -1,10 +1,15 @@
 import { throttle, debounce, omit, addGqlError } from '../lib/utils'
 
+const skippAllKeys = {
+  query: '_skipAllQueries',
+  subscription: '_skipAllSubscriptions',
+}
+
 export default class SmartApollo {
   type = null
   vueApolloSpecialKeys = []
 
-  constructor (vm, key, options, autostart = true) {
+  constructor (vm, key, options) {
     this.vm = vm
     this.key = key
     this.initialOptions = options
@@ -14,10 +19,6 @@ export default class SmartApollo {
     this._watchers = []
     this._destroyed = false
     this.lastApolloOptions = null
-
-    if (autostart) {
-      this.autostart()
-    }
   }
 
   autostart () {
@@ -26,7 +27,7 @@ export default class SmartApollo {
         immediate: true,
         deep: this.options.deep,
       })
-    } else if (!this.options.skip) {
+    } else if (!this.options.skip && !this.allSkip) {
       this.start()
     } else {
       this._skip = true
@@ -68,14 +69,18 @@ export default class SmartApollo {
   }
 
   set skip (value) {
-    if (value) {
+    if (value || this.allSkip) {
       this.stop()
     } else {
       this.start()
     }
     this._skip = value
   }
 
+  get allSkip () {
+    return this.vm.$apollo[skippAllKeys[this.type]]
+  }
+
   refresh () {
     if (!this._skip) {
       this.stop()

packages/vue-apollo/src/smart-query.js

@@ -15,7 +15,7 @@ export default class SmartQuery extends SmartApollo {
       })
     }
 
-    super(vm, key, options, false)
+    super(vm, key, options)
 
     if (vm.$isServer) {
       this.firstRun = new Promise((resolve, reject) => {

packages/vue-apollo/src/smart-subscription.js

@@ -11,6 +11,14 @@ export default class SmartSubscription extends SmartApollo {
     'linkedQuery',
   ]
 
+  constructor (vm, key, options, autostart = true) {
+    super(vm, key, options)
+
+    if (autostart) {
+      this.autostart()
+    }
+  }
+
   executeApollo (variables) {
     const variablesJson = JSON.stringify(variables)
     if (this.sub) {