Skip to content

Clarify how images are loaded, and that they don't depend on CSP #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcoscaceres opened this issue Jun 30, 2020 · 7 comments · May be fixed by #1171
Open

Clarify how images are loaded, and that they don't depend on CSP #910

marcoscaceres opened this issue Jun 30, 2020 · 7 comments · May be fixed by #1171

Comments

@marcoscaceres
Copy link
Member

See:
https://html.spec.whatwg.org/multipage/infrastructure.html#critical-subresources

Applies to shortcuts and icons.

@aarongustafson aarongustafson self-assigned this Jul 6, 2020
@aarongustafson
Copy link
Collaborator

Make a note about these being critical & needing to be downloaded during processing.

@marcoscaceres
Copy link
Member Author

We need to integrate into the processing algorithm, after processing, they image resources should be downloaded.

@aarongustafson
Copy link
Collaborator

We talked about using CSS as an example… progress with this has been slow over there: w3c/csswg-drafts#1088

@aarongustafson
Copy link
Collaborator

@marcoscaceres Per whatwg/html#5581 (comment), it seems like we may not need to do this task right now, no?

@marcoscaceres
Copy link
Member Author

Correct, but we do need to do it when processing happens so definitely as part of CR... but happy to wait until scope and start URL are all sorted.

@marcoscaceres marcoscaceres changed the title Define image resource things as "critical sub-resources" Define when to fetch subresources (icons and shortcuts) + which client to use Jul 15, 2020
@aarongustafson aarongustafson removed their assignment Oct 25, 2021
@marcoscaceres
Copy link
Member Author

This is both applicable and not... firstly, upon reflection, we should not assume there is a client at all because the way this is commonly implemented is that the manifest structure is handed off to the OS to deal with... once it enters the OS, it no longer has a (web) client... it's potentially just using OS-level mechanisms to load the images.

From a security perspective, the only assurances that we give is that it's some kind of image format (which yes, it may attempt to attack the OS) - but generally the image formats are considered safe, and CSP doesn't apply anymore as there is no document object or environment settings object at that point (it's all OS widgets).

So, we should say something ... but we need to figure out what... but it's not a "clients" thing.

@marcoscaceres marcoscaceres changed the title Define when to fetch subresources (icons and shortcuts) + which client to use Clarify how images are loaded, and that they don't depend on CSP Mar 20, 2025
@marcoscaceres
Copy link
Member Author

Also the conclusion is that icons are not critical sub-resources, because the UA can (and often does) provide a fallback icon.

@christianliebel christianliebel linked a pull request Apr 24, 2025 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants