Skip to content

Commit b040a82

Browse files
authored
Merge pull request #775 from solomonkinard/resilient
IconVariants: Correct spelling & address svg and empty icon_variants
2 parents 326a0a4 + d5b2c2c commit b040a82

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

proposals/dark_mode_extension_icons.md

+7-3
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ menus.create(menusProperties);
109109
menus.update(id, menusProperties);
110110
```
111111

112-
A benefit of this new structure is that it's more resiliant to future changes,
112+
A benefit of this new structure is that it's more resilient to future changes,
113113
thus allowing for more keys such as density (e.g. 2dppx), purpose (e.g.
114114
monochrome), and etc.
115115

@@ -166,10 +166,14 @@ effectively have a wild-card for `color_schemes`. For example, `["*"]` is valid.
166166
**Misc**
167167
1. If the top-level `icon_variants` key is provided, the top level `icons` key
168168
will be ignored.
169-
1. `icon_variants` will not cause an error in the event that it is invalid.
169+
1. `icon_variants` will not cause hard errors if no icon groups are found or
170+
specific icon groups have unknown properties. It may cause a hard error if icon
171+
groups are not of type object.
170172
Instead, only the faulty icon group(s) will be ignored, with an optional
171173
warning. Warnings are preferred over errors because they're more adaptable to
172-
changes in the future.
174+
changes in the future. If none of the icon groups are valid, agents can
175+
fallback to the `icons` property in `manifest.json`. If `icons` is
176+
missing, agents are expected not to give a hard error, but can yield a warning.
173177
1. `color-schemes`. Any icon group that does not contain a `color_schemes` key
174178
will apply to all available options, e.g. both "light" and "dark".
175179
1. **Group**. If only one icon group is supplied, it will be used as the

0 commit comments

Comments
 (0)