Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are wrappers for the coinbase-pro api necessary? #1

Open
jkahanec opened this issue Aug 10, 2020 · 1 comment
Open

Are wrappers for the coinbase-pro api necessary? #1

jkahanec opened this issue Aug 10, 2020 · 1 comment

Comments

@jkahanec
Copy link
Collaborator

https://github.com/aleem-ahmed/eccentric-trader/blob/0691dce6c969561bb316a21b45a4296e3b030437/client/coinbase/CBAuthClient.js#L26
https://github.com/aleem-ahmed/eccentric-trader/blob/0691dce6c969561bb316a21b45a4296e3b030437/client/coinbase/CBPublicClient.js#L15

Why do these classes exist? are they necessary? Why can you not just call the API directly?

It looks like you were attempting to make a Shim, but it turned out to be a Middle Man.

@aleem-ahmed
Copy link
Collaborator

this is a valid point you are making.. i cannot give a clear answer as to why this exists. maybe in the future, I might need to make some modifications to the params before sending a request to the API. but as of yet, there is pretty much no reason for it to exist except to keep things organized for me as the dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants