Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to set ulClass #3

Open
ghost opened this issue Nov 29, 2010 · 4 comments
Open

Make it possible to set ulClass #3

ghost opened this issue Nov 29, 2010 · 4 comments

Comments

@ghost
Copy link

ghost commented Nov 29, 2010

I think it was very nice if we can set the ulClass of each item.

like this:
$menu->addChild('Homepage', '@homepage');
$menu['Homepage']->ulClass('subnav')->addChild('About Us', '@about_us');
$menu['Homepage']->addChild('other_link', '#');
$menu->addChild('Blog', '@blog');
$menu['Homepage']->ulClass('blog_subnav')->addChild('Archive', '@blog_archive');
$menu['Homepage']->addChild('other_link', '#');

@weaverryan
Copy link
Owner

Hey-

After my message back to you earlier, do you still think this is necessary? you should add the class to the parent li that houses the children you want to target. If you doesn't work for some reason, please show me an example.

Thanks

@ghost
Copy link
Author

ghost commented Nov 30, 2010

i know is not possible but this is a request to make it possible, and above is an example what i mean, not more.

But forgot it i try another solutions.

thanks

@weaverryan
Copy link
Owner

I certainly don't think it would be difficult to implement, but in general, if the library has less features then it's easier to maintain and document. I'm all for adding this, but only if it were absolutely necessary to accomplish something.

thanks

@ghost
Copy link
Author

ghost commented Dec 7, 2010

Ok.
I think its a must have, to have a higher configurable Menus, i port different styles and i dont like to change all the css, because i can't set it via the Menu plugin i think it was much easier to have the ability to change ul li classes, ok for li this is available.

for example the diem Menu make exactly that, but for my actual project i don't want use diem.

Your plugin does all the stuff i need but the only one with ul Classes, and your Plugin is absolute perfect. :-)

thanks too...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant