chmod

Author: fi3ework

Cargo.lock

@@ -11,6 +11,7 @@ type Write = ThreadsafeFunction<FnArgs<(i32, Buffer, u32)>, Promise<Either<u32,
 type Read = ThreadsafeFunction<FnArgs<(i32, u32, u32)>, Promise<Either<Buffer, ()>>>;
 type ReadUtil = ThreadsafeFunction<FnArgs<(i32, u8, u32)>, Promise<Either<Buffer, ()>>>;
 type ReadToEnd = ThreadsafeFunction<FnArgs<(i32, u32)>, Promise<Either<Buffer, ()>>>;
+type Chmod = ThreadsafeFunction<FnArgs<(String, u32)>, Promise<()>>;
 
 #[derive(Debug)]
 #[napi(object, object_to_js = false, js_name = "ThreadsafeNodeFS")]
@@ -53,7 +54,7 @@ pub struct ThreadsafeNodeFS {
   pub read_to_end: ReadToEnd,
   // The following functions are not supported by webpack, so they are optional
   #[napi(ts_type = "(name: string, mode: number) => Promise<void>")]
-  pub chmod: Option<ThreadsafeFunction<(String, u32), Promise<()>>>,
+  pub chmod: Option<Chmod>,
 }
 
 #[napi(object, object_to_js = false)]

crates/rspack_binding_api/src/fs_node/node.rs

@@ -134,7 +134,10 @@ impl WritableFileSystem for NodeFileSystem {
       && let Some(chmod) = &self.0.chmod
     {
       let file = path.as_str().to_string();
-      return chmod.call_with_promise((file, mode)).await.to_fs_result();
+      return chmod
+        .call_with_promise((file, mode).into())
+        .await
+        .to_fs_result();
     }
     Ok(())
   }

crates/rspack_binding_api/src/fs_node/write.rs

@@ -101,7 +101,7 @@ impl EsmLibraryPlugin {
         chunk_init_fragments.insert(
           0,
           Box::new(rspack_core::NormalInitFragment::new(
-            format!("{}\n", hashbang),
+            format!("{hashbang}\n"),
             rspack_core::InitFragmentStage::StageConstants,
             i32::MIN,
             rspack_core::InitFragmentKey::unique(),
@@ -117,7 +117,7 @@ impl EsmLibraryPlugin {
           chunk_init_fragments.insert(
             insert_pos,
             Box::new(rspack_core::NormalInitFragment::new(
-              format!("{}\n", directive),
+              format!("{directive}\n"),
               rspack_core::InitFragmentStage::StageConstants,
               i32::MIN + 1 + idx as i32,
               rspack_core::InitFragmentKey::unique(),

crates/rspack_plugin_esm_library/src/render.rs

@@ -11,6 +11,7 @@ version.workspace = true
 rspack_cacheable         = { workspace = true }
 rspack_core              = { workspace = true }
 rspack_error             = { workspace = true }
+rspack_fs                = { workspace = true }
 rspack_hash              = { workspace = true }
 rspack_hook              = { workspace = true }
 rspack_plugin_asset      = { workspace = true }

crates/rspack_plugin_rslib/Cargo.toml

@@ -4,9 +4,9 @@ use std::{
 };
 
 use rspack_core::{
-  ChunkUkey, Compilation, CompilationParams, CompilerCompilation, CompilerFinishMake, ModuleType,
-  NormalModuleFactoryParser, ParserAndGenerator, ParserOptions, Plugin, get_module_directives,
-  get_module_hashbang,
+  AssetEmittedInfo, ChunkUkey, Compilation, CompilationParams, CompilerAssetEmitted,
+  CompilerCompilation, CompilerFinishMake, ModuleType, NormalModuleFactoryParser,
+  ParserAndGenerator, ParserOptions, Plugin, get_module_directives, get_module_hashbang,
   rspack_sources::{ConcatSource, RawStringSource, SourceExt},
 };
 use rspack_error::Result;
@@ -179,6 +179,30 @@ async fn finish_make(&self, compilation: &mut Compilation) -> Result<()> {
   Ok(())
 }
 
+#[plugin_hook(CompilerAssetEmitted for RslibPlugin)]
+async fn asset_emitted(
+  &self,
+  compilation: &Compilation,
+  _filename: &str,
+  info: &AssetEmittedInfo,
+) -> Result<()> {
+  use rspack_core::rspack_sources::Source;
+  use rspack_fs::FilePermissions;
+
+  // Check if the file content starts with a hashbang
+  let content = info.source.source().into_string_lossy();
+  if content.starts_with("#!") {
+    // Set file permissions to 0o755 (rwxr-xr-x) using the file system interface
+    // This will work on Unix/macOS and be a no-op on Windows/WASM
+    let output_fs = &compilation.output_filesystem;
+    let permissions = FilePermissions::from_mode(0o755);
+    output_fs
+      .set_permissions(&info.target_path, permissions)
+      .await?;
+  }
+  Ok(())
+}
+
 impl Plugin for RslibPlugin {
   fn name(&self) -> &'static str {
     "rslib"
@@ -192,6 +216,10 @@ impl Plugin for RslibPlugin {
       .tap(nmf_parser::new(self));
 
     ctx.compiler_hooks.finish_make.tap(finish_make::new(self));
+    ctx
+      .compiler_hooks
+      .asset_emitted
+      .tap(asset_emitted::new(self));
 
     Ok(())
   }