diff --git a/.github/workflows/ecosystem-benchmark.yml b/.github/workflows/ecosystem-benchmark.yml index e282be171c98..607743d0b10b 100644 --- a/.github/workflows/ecosystem-benchmark.yml +++ b/.github/workflows/ecosystem-benchmark.yml @@ -24,6 +24,9 @@ permissions: # Allow commenting on pull requests pull-requests: write +env: + # we are going to build release profile for benchmark + CARGO_INCREMENTAL: 1 jobs: build: name: Test Linux diff --git a/.github/workflows/reusable-build-bench.yml b/.github/workflows/reusable-build-bench.yml index 947f62a7d450..7fc210cfc596 100644 --- a/.github/workflows/reusable-build-bench.yml +++ b/.github/workflows/reusable-build-bench.yml @@ -15,7 +15,7 @@ on: env: # Since CI builds are more akin to from-scratch builds, incremental compilation adds unnecessary dependency-tracking and IO overhead, reducing caching effectiveness. # https://github.com/rust-lang/rust-analyzer/blob/25368d24308d6a94ffe8b99f0122bcf5a2175322/.github/workflows/ci.yaml#L11 - CARGO_INCREMENTAL: 0 + CARGO_INCREMENTAL: 1 permissions: # Allow commenting on issues diff --git a/.github/workflows/reusable-build-build.yml b/.github/workflows/reusable-build-build.yml index a964ac1fbcdb..7611db9a4ce0 100644 --- a/.github/workflows/reusable-build-build.yml +++ b/.github/workflows/reusable-build-build.yml @@ -24,7 +24,7 @@ on: env: # Since CI builds are more akin to from-scratch builds, incremental compilation adds unnecessary dependency-tracking and IO overhead, reducing caching effectiveness. # https://github.com/rust-lang/rust-analyzer/blob/25368d24308d6a94ffe8b99f0122bcf5a2175322/.github/workflows/ci.yaml#L11 - CARGO_INCREMENTAL: 0 + CARGO_INCREMENTAL: 1 jobs: build: @@ -64,7 +64,7 @@ jobs: - name: Install Rust Toolchain uses: ./.github/actions/rustup with: - key: ${{ inputs.target }}-${{ inputs.profile }} + key: ${{ inputs.target }}-${{ inputs.profile }}-pshu-1-${{ inputs.prefer_docker == 'true' && 'docker' || 'native' }} # don't need use cache in self-hosted windows; benefits of build with cargo build are wasted by cache restore save-if: true @@ -92,7 +92,9 @@ jobs: if: ${{ inputs.target == 'x86_64-unknown-linux-gnu' && !inputs.prefer_docker }} run: | rustup target add x86_64-unknown-linux-gnu - RUST_TARGET=x86_64-unknown-linux-gnu pnpm build:binding:${{ inputs.profile }} + CARGO_INCREMENTAL=1 RUST_TARGET=x86_64-unknown-linux-gnu pnpm build:binding:${{ inputs.profile }} + + - uses: ./.github/actions/debugger - name: Build x86_64-unknown-linux-gnu in Docker if: ${{ inputs.target == 'x86_64-unknown-linux-gnu' && inputs.prefer_docker }} diff --git a/crates/node_binding/scripts/build.js b/crates/node_binding/scripts/build.js index 1254fb8372f2..6fdb1d247276 100644 --- a/crates/node_binding/scripts/build.js +++ b/crates/node_binding/scripts/build.js @@ -38,6 +38,7 @@ async function build() { "--no-js", // "--no-const-enum", "--no-dts-header", + "-v", "--pipe", `"node ${path.resolve(__dirname, "dts-header.js")}"` ];