Add support for sprintf in BackedEnum

Author: Thibaut Chieux

src/Symfony/Component/Translation/Extractor/Visitor/BackedEnumVisitor.php

@@ -106,6 +106,11 @@ private function resolveMessagePattern(Node\Expr $expr): ?string
         }
 
         $parts[] = $this->resolveExprPart($expr);
+        // If there is only one string part and does not contains sprintf value(s), TransMethodVisitor already extracted the key.
+        if (1 === \count($parts) && !str_contains($parts[0], '{value}') && !str_contains($parts[0], '{name}')) {
+            return null;
+        }
+
         $parts = array_reverse($parts);
 
         // If any part failed to resolve, abort
@@ -137,6 +142,17 @@ private function resolveExprPart(Node\Expr $expr): ?string
             }
         }
 
+        if (
+            $expr instanceof Node\Expr\FuncCall &&
+            $expr->name->name === 'sprintf'
+        ) {
+            $args = $expr->args;
+            $pattern = array_shift($args)->value->value;
+            array_walk($args, fn (Node\Arg &$arg) => $arg = $this->resolveExprPart($arg->value));
+
+            return vsprintf($pattern, $args);
+        }
+
         return null; // unsupported part
     }
 

src/Symfony/Component/Translation/Tests/Extractor/Visitor/BackedEnumVisitorTest.php

@@ -4,8 +4,6 @@
 
 use PhpParser\NodeVisitor;
 use Symfony\Component\Translation\Extractor\Visitor\BackedEnumVisitor;
-use Symfony\Component\Translation\Extractor\Visitor\FormTypeVisitor;
-use Symfony\Component\Translation\Extractor\Visitor\TransMethodVisitor;
 use Symfony\Component\Translation\MessageCatalogue;
 
 class BackedEnumVisitorTest extends AbstractVisitorTest
@@ -32,6 +30,9 @@ public function assertCatalogue(MessageCatalogue $catalogue): void
                     'backed_enum.value_concatenation.foo.label' => 'prefixbacked_enum.value_concatenation.foo.label',
                     'backed_enum.both_concatenation.Foo_foo' => 'prefixbacked_enum.both_concatenation.Foo_foo',
                     'backed_enum.value_concatenation.0' => 'prefixbacked_enum.value_concatenation.0',
+                    'backed_enum.value_sprintf.foo' => 'prefixbacked_enum.value_sprintf.foo',
+                    'backed_enum.value_sprintf.Foo.foo' => 'prefixbacked_enum.value_sprintf.Foo.foo',
+                    'backed_enum.value_sprintf.foo.name_concatenation.Foo' => 'prefixbacked_enum.value_sprintf.foo.name_concatenation.Foo',
                 ],
             ],
             $catalogue->all(),

src/Symfony/Component/Translation/Tests/Fixtures/extractor-php-ast/backed-enum-visitor/backed-enum.html.php

@@ -53,3 +53,33 @@ public function trans(TranslatorInterface $translator, ?string $locale = null):
         return $translator->trans('backed_enum.value_concatenation.'.$this->value, locale: $locale);
     }
 }
+
+enum BackedEnumWithSprintf: string implements TranslatableInterface
+{
+    case Foo = 'foo';
+
+    public function trans(TranslatorInterface $translator, ?string $locale = null): string
+    {
+        return $translator->trans(sprintf('backed_enum.value_sprintf.%s', $this->value), locale: $locale);
+    }
+}
+
+enum BackedEnumWithTwoArgumentsInSprintf: string implements TranslatableInterface
+{
+    case Foo = 'foo';
+
+    public function trans(TranslatorInterface $translator, ?string $locale = null): string
+    {
+        return $translator->trans(sprintf('backed_enum.value_sprintf.%s.%s', $this->name, $this->value), locale: $locale);
+    }
+}
+
+enum BackedEnumWithSprintfAndConcatenation: string implements TranslatableInterface
+{
+    case Foo = 'foo';
+
+    public function trans(TranslatorInterface $translator, ?string $locale = null): string
+    {
+        return $translator->trans(sprintf('backed_enum.value_sprintf.%s', $this->value).'.name_concatenation.'.$this->name, locale: $locale);
+    }
+}