#define FOO(X) (int) X is handled wrong.

[phadej]

I see

            +DeclMacro
              MacroDecl {
                macroDeclMacro = Macro {
                  macroLoc = MultiLoc {
                    multiLocExpansion =
                    "macro_functions.h:16:9",
                    multiLocPresumed = Nothing,
                    multiLocSpelling = Nothing,
                    multiLocFile = Nothing},
                  macroName = CName "FOO",
                  macroArgs = [CName "X"],
                  macroBody = MTerm
                    (MType
                      (TypePrim
                        (PrimIntegral
                          PrimInt
                          Signed)))},
                macroDeclMacroTy =
                "(forall a. (a -> PrimTy))",

in test output. The body is incorrect, I assume parser goes wrong.

[phadej]

Note that

#define FOO(X) ((int) X)

with extra parentheses does

            +DeclMacro
              MacroTcError {
                macroTcErrorMacro = Macro {
                  macroLoc = MultiLoc {
                    multiLocExpansion =
                    "macro_functions.h:16:9",
                    multiLocPresumed = Nothing,
                    multiLocSpelling = Nothing,
                    multiLocFile = Nothing},
                  macroName = CName "FOO",
                  macroArgs = [],
                  macroBody = MTerm
                    (MVar (CName "X") [])},
                macroTcError = T.concat
                  [
                    "Failed to typecheck macro:\n",
                    "Unbound variable: 'X'\n"]}])

which is different, but also wrong.

[edsko]

I think we should just fail to parse both of these examples; they don't need to be supported.