-
Notifications
You must be signed in to change notification settings - Fork 3k
[Origin API] Define an Origin interface. (#11534)
#11846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mikewest
wants to merge
2
commits into
whatwg:main
Choose a base branch
from
mikewest:origin-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch shifts the normative portions of https://mikewest.github.io/origin-api/ into a patch against HTML for discussion. As a followup, this will require changes to [[URL]] and [[ServiceWorker]] as well to define the "extract an origin" for relevant objects. See discussion in w3ctag/design-reviews#1130, WebKit/standards-positions#538, and mozilla/standards-positions#1280.
This was referenced Nov 5, 2025
Member
|
I would like to see mikewest/origin-api#6 addressed. |
annevk
reviewed
Nov 6, 2025
Member
annevk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some editorial comments. Generally this looks good to me.
philwo
pushed a commit
to philwo/chromium
that referenced
this pull request
Nov 7, 2025
whatwg/html#11846 (comment) noted that we should verify schemeful same-site comparison; this CL adds that test. Bug: 434131026 Change-Id: I48878979fc0f8c3dab2caefbe788a14d367e053b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7130621 Reviewed-by: Antonio Sartori <[email protected]> Commit-Queue: Mike West <[email protected]> Cr-Commit-Position: refs/heads/main@{#1541759}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 7, 2025
whatwg/html#11846 (comment) noted that we should verify schemeful same-site comparison; this CL adds that test. Bug: 434131026 Change-Id: I48878979fc0f8c3dab2caefbe788a14d367e053b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7130621 Reviewed-by: Antonio Sartori <[email protected]> Commit-Queue: Mike West <[email protected]> Cr-Commit-Position: refs/heads/main@{#1541759}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 7, 2025
whatwg/html#11846 (comment) noted that we should verify schemeful same-site comparison; this CL adds that test. Bug: 434131026 Change-Id: I48878979fc0f8c3dab2caefbe788a14d367e053b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7130621 Reviewed-by: Antonio Sartori <[email protected]> Commit-Queue: Mike West <[email protected]> Cr-Commit-Position: refs/heads/main@{#1541759}
lando-prod-mozilla bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Nov 11, 2025
… schemeful., a=testonly Automatic update from web-platform-tests [Origin API] Verify that comparisons are schemeful. whatwg/html#11846 (comment) noted that we should verify schemeful same-site comparison; this CL adds that test. Bug: 434131026 Change-Id: I48878979fc0f8c3dab2caefbe788a14d367e053b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7130621 Reviewed-by: Antonio Sartori <[email protected]> Commit-Queue: Mike West <[email protected]> Cr-Commit-Position: refs/heads/main@{#1541759} -- wpt-commits: 08b913918dd419fe48d01ef685781a69ced0a111 wpt-pr: 55938
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Nov 12, 2025
… schemeful., a=testonly Automatic update from web-platform-tests [Origin API] Verify that comparisons are schemeful. whatwg/html#11846 (comment) noted that we should verify schemeful same-site comparison; this CL adds that test. Bug: 434131026 Change-Id: I48878979fc0f8c3dab2caefbe788a14d367e053b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7130621 Reviewed-by: Antonio Sartori <[email protected]> Commit-Queue: Mike West <[email protected]> Cr-Commit-Position: refs/heads/main@{#1541759} -- wpt-commits: 08b913918dd419fe48d01ef685781a69ced0a111 wpt-pr: 55938
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Nov 12, 2025
… schemeful., a=testonly Automatic update from web-platform-tests [Origin API] Verify that comparisons are schemeful. whatwg/html#11846 (comment) noted that we should verify schemeful same-site comparison; this CL adds that test. Bug: 434131026 Change-Id: I48878979fc0f8c3dab2caefbe788a14d367e053b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7130621 Reviewed-by: Antonio Sartori <antoniosartorichromium.org> Commit-Queue: Mike West <mkwstchromium.org> Cr-Commit-Position: refs/heads/main{#1541759} -- wpt-commits: 08b913918dd419fe48d01ef685781a69ced0a111 wpt-pr: 55938 UltraBlame original commit: 313ef5bf80f71a4e57fc5bebfd0d784dd667b024
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Nov 13, 2025
… schemeful., a=testonly Automatic update from web-platform-tests [Origin API] Verify that comparisons are schemeful. whatwg/html#11846 (comment) noted that we should verify schemeful same-site comparison; this CL adds that test. Bug: 434131026 Change-Id: I48878979fc0f8c3dab2caefbe788a14d367e053b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7130621 Reviewed-by: Antonio Sartori <antoniosartorichromium.org> Commit-Queue: Mike West <mkwstchromium.org> Cr-Commit-Position: refs/heads/main{#1541759} -- wpt-commits: 08b913918dd419fe48d01ef685781a69ced0a111 wpt-pr: 55938 UltraBlame original commit: 313ef5bf80f71a4e57fc5bebfd0d784dd667b024
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Nov 13, 2025
… schemeful., a=testonly Automatic update from web-platform-tests [Origin API] Verify that comparisons are schemeful. whatwg/html#11846 (comment) noted that we should verify schemeful same-site comparison; this CL adds that test. Bug: 434131026 Change-Id: I48878979fc0f8c3dab2caefbe788a14d367e053b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7130621 Reviewed-by: Antonio Sartori <antoniosartorichromium.org> Commit-Queue: Mike West <mkwstchromium.org> Cr-Commit-Position: refs/heads/main{#1541759} -- wpt-commits: 08b913918dd419fe48d01ef685781a69ced0a111 wpt-pr: 55938 UltraBlame original commit: 313ef5bf80f71a4e57fc5bebfd0d784dd667b024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch shifts the normative portions of
https://mikewest.github.io/origin-api/ into a patch against HTML for discussion.
As a followup, this will require changes to [[URL]] and [[ServiceWorker]] as well to define the "extract an origin" for relevant objects.
See discussion in w3ctag/design-reviews#1130, WebKit/standards-positions#538, and mozilla/standards-positions#1280.
OriginObject WebKit/standards-positions#538 is inconclusive, though @annevk and @marcoscaceres have provided positive feedback.OriginObject mozilla/standards-positions#1280 is similarly inconclusive.(See WHATWG Working Mode: Changes for more details.)
/browsers.html ( diff )
/comms.html ( diff )
/index.html ( diff )
/links.html ( diff )
/nav-history-apis.html ( diff )
/webappapis.html ( diff )
/workers.html ( diff )