Great plugin!, but fails on etherscan-verify

[iangregsondev]

Hi,

Great plugin, although etherscan fails - i presume this is because etherscan-verify plugin isn't in the same pipeline or something so it doesn't get run - so hence the files are different ?

The only thing I was doing was removing "console.log"

  preprocess: {
    eachLine: removeConsoleLog((hre) => hre.network.name !== 'hardhat' && hre.network.name !== 'localhost'),
  },

This is the error (npx hardhat etherscan-verify --network bsc_mainnet)

Failed to verify contract Token: NOTOK, Fail - Unable to verify
{
  "apikey": "XXXXXX",
  "module": "contract",
  "action": "verifysourcecode",

[wighawag]

Thanks for the report.

That could be a problem with etherscan-verify.

If you use hardhat-deploy that include a task to verify contract on etherscan and sourcify it should work

[iangregsondev]

Thanks for the quick response.

Actually, I am using hardhat-deploy, and I think I am doing it right

https://github.com/wighawag/hardhat-deploy#4-hardhat-etherscan-verify

But it fails.

I am doing

 npx hardhat deploy --network bsc_mainnet

and then..

 npx hardhat etherscan-verify --network bsc_mainnet

[wighawag]

That could be something else, as hardhat-deploy etherscan-verify use the metadata outputed by the compiler used for deployment. It should thus be exactly same. You can look up the source in the metadata field of your deployed contract ( in the deployments/bsc_mainnet folder) and see if your preprocessing was applied there.

…

On Sun, Jul 11, 2021, 19:04 Ian Gregson ***@***.***> wrote: Thanks for the quick response. Actually, I am using hardhat-deploy, and I think I am doing it right https://github.com/wighawag/hardhat-deploy#4-hardhat-etherscan-verify But it fails. I am doing npx hardhat deploy --network bsc_mainnet and then.. npx hardhat etherscan-verify --network bsc_mainnet — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#12 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGBANAB3ARHKKXVJW62WQ3TXHFLRANCNFSM5AFNZ66Q> .

[Shelvak]

I was creating an issue in hardhat before discover that pre-process was the problem. I use the plugin to change addresses from test to mainnet/testnet. At least for me the verify process verifies the contract but with all the project files. I use tenderly too to verify with:

const contract = await (await hre.ethers.getContractFactory('UniZap')).deploy()
await contract.deployed();
await hre.tenderly.verify({ name: 'UniZap', address: contract.address }) 15 files verified (as expected)
await hre.run('verify:verify', { address: contract.address, contract: `contracts/UniZap.sol:UniZap` }) # 51 files verified

https://mumbai.polygonscan.com/address/0xd107ab4fb0ca23ad2e4e99017dfc73e567a246ef#code # 51 files verified
https://dashboard.tenderly.co/contract/mumbai/0xd107ab4fb0ca23ad2e4e99017dfc73e567a246ef/source # 15 files verified as expected

If I comment the preprocess lines in my hardhat config the verify line works as expected.
I can verify my contracts with "single file" changing manually the addresses too...
https://mumbai.polygonscan.com/address/0xa067f8559462594521af6ce3bb0658beb33078e4#code (single file manual verification)

EDIT: Making some local changes on preprocessor & etherscan plugin I can't find the point where the the addresses are not changed. Every object generated by the tasks are with the addresses changed, but with other bytecode... Sorry to not be more helpful.

[wighawag]

As my comment above state, if you use hardhat-deploy's builtin verification task: etherscan-verify it should work

You are using thrird party tools that are attempting to recompile the contract to get the bytecode and they assume you did not change the code since last deployment

I would create an issue on their side as their tool will be affected by any plugin that preprocess source code. hardhat-deploy etherscan-verify is not affected.

[fedealconada]

@wighawag I was having this same issue and using the built-in verification task made the trick BUT I had to use the --solc-input param (which I'm not supposed to since I'm using 0.8.13).
Any idea?

Also, after verifying, I'm getting the CACHE_BREAKER warning on Etherscan (but you could answer this question here: wighawag/hardhat-deploy#78 (comment))

Thanks 🙂!