Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Literature reference marks are not displaying on some pathways #378

Open
khanspers opened this issue Dec 4, 2015 · 9 comments
Open

Literature reference marks are not displaying on some pathways #378

khanspers opened this issue Dec 4, 2015 · 9 comments
Assignees

Comments

@khanspers
Copy link
Member

This pathway has a lot of literature references for many of the data nodes, but none of them display in the viewer: http://wikipathways.org/index.php/Pathway:WP722

They are visible in PathVisio. See attached for comparison.

This pathway has one lit ref (for the PDIA2/MTTP complex) that is visible in the viewer: http://wikipathways.org/index.php/Pathway:WP430

However, a second pathway-level lit ref is not visible next to the pathway information box as expected.

Observed in Chrome, FF and Safari.
screen shot 2015-12-04 at 9 50 02 am
screen shot 2015-12-04 at 9 49 51 am

@khanspers khanspers added the bug label Dec 4, 2015
@ariutta
Copy link
Member

ariutta commented Dec 4, 2015

It looks as if the lit refs that fail to display are all for interactions,
right?

On Fri, Dec 4, 2015 at 9:50 AM, khanspers [email protected] wrote:

This pathway has a lot of literature references for many of the data
nodes, but none of them display in the viewer:
http://wikipathways.org/index.php/Pathway:WP722

They are visible in PathVisio. See attached for comparison.

This pathway has one lit ref (for the PDIA2/MTTP complex) that is visible
in the viewer: http://wikipathways.org/index.php/Pathway:WP430

However, a second pathway-level lit ref is not visible next to the pathway
information box as expected.

Observed in Chrome, FF and Safari.
[image: screen shot 2015-12-04 at 9 50 02 am]
https://cloud.githubusercontent.com/assets/1442197/11596836/77fc596c-9a6c-11e5-9ce1-0c4563fc9041.png
[image: screen shot 2015-12-04 at 9 49 51 am]
https://cloud.githubusercontent.com/assets/1442197/11596835/77fc38c4-9a6c-11e5-88cf-6838d96b5ead.png


Reply to this email directly or view it on GitHub
#378.

@ariutta
Copy link
Member

ariutta commented Dec 4, 2015

Oh, "pathway-level" meaning not on any specific node. @AlexanderPico, didn't you say you didn't want those to show up?

So two issues:

  1. Lits refs on interactions
  2. Pathway-level lit refs

@AlexanderPico
Copy link
Member

Re: 2... I don't consider the viewing of numbers on the info box to be all that useful. It's just as easy to deduce that all the references that aren't on a specific node or interaction are for the whole pathway.

I wouldn't be against it if it was a byproduct of other fixes, but I wouldn't want to take time to implement it as a special case.

@khanspers
Copy link
Member Author

Re interactions: yes, it appears the missing references are for interactions. Did we decide against displaying these? If so, please close this.

@ariutta
Copy link
Member

ariutta commented Dec 9, 2015

@AlexanderPico, you would prefer that:

  • references for interactions ARE shown
  • pathway-level references ARE NOT shown

right? If so, we need to leave this open for the interaction references.

@AlexanderPico
Copy link
Member

Right

@khanspers
Copy link
Member Author

Literature references are still not showing on interactions on some pathways:

Not visible on this pathway: http://www.wikipathways.org/index.php/Pathway:WP4018

But visible on this one: http://www.wikipathways.org/index.php/Pathway:WP554

@AlexanderPico
Copy link
Member

Ok. This bug is now focused on displaying literature refs on the interactions. I don't see these on WP4018 nor on WP554, for example. Refs on the infobox are not an issue, we are going to ditch that box entirely anyways.

@AlexanderPico AlexanderPico modified the milestones: editor-v2, react-based-v2+ Oct 27, 2017
@AlexanderPico
Copy link
Member

@hasanbalci Here's another feature that we used to have and might be easy to turn on again (or provide GUI toggle to hide/show?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants