Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add ability to toggle worker log output #5177

Open
myoung34 opened this issue Jan 30, 2025 · 0 comments
Open

feature: Add ability to toggle worker log output #5177

myoung34 opened this issue Jan 30, 2025 · 0 comments
Assignees

Comments

@myoung34
Copy link

myoung34 commented Jan 30, 2025

  • I have configured an environment variable SOME_ENV_VAR with a sensitive value on a worker, and allowed it with WHITELIST_ENVS="SOME_ENV_VAR"
  • When the worker starts up, it dumps the environment variables to stdout, which can be (in this case is) sensitive
  • Logging software would pick this up and store it with the sensitive value
$ cat logs | grep sensitive\ value | jq .message

"listening for jobs, WORKER_GROUP: default, config: WorkerConfig { worker_tags: 
[\"ansible\", \"bash\", \"bun\", \"csharp\", \"deno\", \"dependency\", \"flow\", \"go\", 
\"hub\", \"other\", \"php\", \"powershell\", \"python3\", \"rust\"], priority_tags_sorted: 
[PriorityTags { priority: 0, tags: [\"ansible\", \"bash\", \"bun\", \"csharp\", \"deno\", 
\"dependency\", \"flow\", \"go\", \"hub\", \"other\", \"php\", \"powershell\", \"python3\", 
\"rust\"] }], dedicated_worker: None, init_bash: None, cache_clear: None, 
additional_python_paths: None, pip_local_dependencies: None, 
env_vars: {\"SOME_ENV_VAR\": \"some sensitive value\"} }"

It would be ideal to be able to toggle this so that it does not dump env_vars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants