-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: Self-hosted worker report can not have INIT_SCRIPT customized through env var #5269
Labels
bug
Something isn't working
Comments
It's because of the lines above. It has init_bash from the DB and the precedence takes the DB value. From my values:
|
Yes, I ended up doing so, but it took a lot of time to figure out. If this
is the correct behavior, then it should be documented
…On Thu, 13 Feb 2025 at 10:58, Jodie Cunningham ***@***.***> wrote:
init_bash: config
.init_bash
.or_else(|| std::env::var("INIT_SCRIPT").ok())
It's because of the lines above. It has init_bash from the DB and the
precedence takes the DB value.
Just don't make a reports workers group, make another group with a
different name. I named mine "scrapers".
From my values:
- name: scrapers
replicas: 2
resources:
requests:
memory: 512Mi
cpu: 100m
limits:
memory: 1024Mi
extraEnv:
- name: "INIT_SCRIPT"
value: "apt-get update\napt-get install -y chromium\npip install playwright\nexport PATH=$PATH:/tmp/.local/bin\nplaywright install\nplaywright install-deps"
- name: "WORKER_TAGS"
value: "chromium"
—
Reply to this email directly, view it on GitHub
<#5269 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGJQUC6NZCXY7MGKJG6RFT2PQC5ZAVCNFSM6AAAAABW4VQ6Q6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJVGM2DEMRVGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: jodiecunningham]*jodiecunningham* left a comment
(windmill-labs/windmill#5269)
<#5269 (comment)>
init_bash: config
.init_bash
.or_else(|| std::env::var("INIT_SCRIPT").ok())
It's because of the lines above. It has init_bash from the DB and the
precedence takes the DB value.
Just don't make a reports workers group, make another group with a
different name. I named mine "scrapers".
From my values:
- name: scrapers
replicas: 2
resources:
requests:
memory: 512Mi
cpu: 100m
limits:
memory: 1024Mi
extraEnv:
- name: "INIT_SCRIPT"
value: "apt-get update\napt-get install -y chromium\npip install playwright\nexport PATH=$PATH:/tmp/.local/bin\nplaywright install\nplaywright install-deps"
- name: "WORKER_TAGS"
value: "chromium"
—
Reply to this email directly, view it on GitHub
<#5269 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGJQUC6NZCXY7MGKJG6RFT2PQC5ZAVCNFSM6AAAAABW4VQ6Q6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJVGM2DEMRVGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
On self-host
INIT_SCRIPT
doesn't work for worker group reports. It will always be:To reproduce
Set
INIT_SCRIPT
on a self host instance and restart containers. Go to the runs and find the init_script tagged run. In the code tab it will be the predefined script instead of the content passed in env var.Expected behavior
INIT_SCRIPT
should be taken into account by the workerScreenshots
No response
Browser information
No response
Application version
Windmill 1.459
Additional Context
No response
The text was updated successfully, but these errors were encountered: