Skip to content

Commit 1db0a1a

Browse files
authored
gundeck: integration test docs (#2754)
* services/gundeck: move appName closer to where it's used * services/gundeck: document SNS Platform Application requirements
1 parent 9d1847c commit 1db0a1a

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Documentation on what SNS platform applications the gundeck integration test expects was added.

services/gundeck/test/integration/API.hs

+7-3
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,6 @@ import Util (runRedisProxy, withSettingsOverrides)
6868
import Wire.API.Internal.Notification
6969
import qualified Prelude
7070

71-
appName :: AppName
72-
appName = AppName "test"
73-
7471
tests :: IO TestSetup -> TestTree
7572
tests s =
7673
testGroup
@@ -736,6 +733,10 @@ testUnregisterClient = do
736733

737734
-----------------------------------------------------------------------------
738735
-- Native push token registration
736+
-- This expects the following SNS Platform applications to be present in AWS:
737+
738+
-- ${env}-test (FCM), ${env}-test (APNS_SANDBOX), ${env}-com.wire.ent (APNS_SANDBOX),
739+
-- with ${env} normally being integration.
739740

740741
testRegisterPushToken :: TestM ()
741742
testRegisterPushToken = do
@@ -1121,6 +1122,9 @@ buildPush sdr rcps pload =
11211122
where
11221123
rcpt u c = recipient u RouteAny & recipientClients .~ c
11231124

1125+
appName :: AppName
1126+
appName = AppName "test"
1127+
11241128
data TokenSpec = TokenSpec {trans :: Transport, tSize :: Int, tName :: AppName}
11251129

11261130
gcmToken :: TokenSpec

0 commit comments

Comments
 (0)