Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve how the code is shared with the container. #52

Open
wkania opened this issue Mar 28, 2021 · 0 comments
Open

Improve how the code is shared with the container. #52

wkania opened this issue Mar 28, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@wkania
Copy link
Owner

wkania commented Mar 28, 2021

Prior to the PR there was one volume for the code. All the containers shared the same path for the vendor. Switching was made with the symlink. There was a problem with including volume with code, so the vendor symlink would be only on the container and not on the host. Git was reporting the symlink file as a change. To fix that, there are multiple volumes and none of them expose vendor in the code directory.

What can be done:

  • symlink is not needed anymore because each vendor is on its own container,
  • maybe there is a way to include code as one volume.
@wkania wkania added the enhancement New feature or request label Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant