-
Notifications
You must be signed in to change notification settings - Fork 0
Finish renaming the plugin #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish renaming the plugin #32
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughRename and rebrand project artifacts: update main plugin filename references, package metadata (name/title/repository), test bootstrap path, and minor PHPDoc and plugin header text across build script, tests, source, and package files. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
package.json
Outdated
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/woocommerce/OpenAI-Product-Feed.git" | ||
| "url": "https://github.com/woocommerce/WooCommerce-Product-Feed.git" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a typo, I just don't know what the long-term repository will be. This will not be published in NPM, so we should be good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also the GitHub repo name too. Anyway, I prefer all characters to be lowercase: woocommerce-product-feed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should change and make it generic WooCommerce Product Feed for everything because this repo is now actually supporting product feeds for both POS and OpenAI specs.
WDYT @ebinnion ?
| FILES_TO_COPY=( | ||
| "./src" | ||
| "./openai-product-feed-for-woo.php" | ||
| "./woocommerce-product-feed-for-openai.php" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May not use for-openai?
| "./woocommerce-product-feed-for-openai.php" | |
| "./woocommerce-product-feed.php" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a big part of the current code here will go into Woo Core at some point, and this plugin will remain OpenAI-specific.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tests/unit/bootstrap.php (1)
6-6: Fix typo in comment.The comment contains "constnat" instead of "constant".
Apply this diff to fix the typo:
-// Define a constnat to use in tests. +// Define a constant to use in tests.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/Core/Plugin.php(1 hunks)tests/unit/bootstrap.php(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- src/Core/Plugin.php
🧰 Additional context used
📓 Path-based instructions (1)
**/*.php
📄 CodeRabbit inference engine (.cursorrules)
When suggesting with Tab or writing code, always obey the WordPress Coding Standards (project PHPCS config in phpcs.xml.dist)
Files:
tests/unit/bootstrap.php
🧠 Learnings (2)
📓 Common learnings
Learnt from: RadoslavGeorgiev
Repo: woocommerce/OpenAI-Product-Feed PR: 13
File: src/API/Controllers/ApiController.php:44-50
Timestamp: 2025-10-22T15:49:57.065Z
Learning: The ApiController in src/API/Controllers/ApiController.php is planned to be moved and refactored to be OpenAI platform-specific, which is why it currently requires concrete ProductMapper and FeedValidator implementations from the OpenAI platform rather than interface types.
📚 Learning: 2025-10-24T17:54:03.161Z
Learnt from: RadoslavGeorgiev
Repo: woocommerce/OpenAI-Product-Feed PR: 21
File: src/Utils/MemoryManager.php:35-60
Timestamp: 2025-10-24T17:54:03.161Z
Learning: In the woocommerce/OpenAI-Product-Feed repository, the MemoryManager::flush_caches() method uses aggressive cache clearing including direct $wp_object_cache property manipulation. This is an intentional, tried & tested pattern copied from another project that is necessary for generating very large product feeds (70k-200k products). Without this aggressive approach, large exports fail. The cache clearing happens after feed processing is complete, before shipping the file to another server, not during normal page execution.
Applied to files:
tests/unit/bootstrap.php
🔇 Additional comments (1)
tests/unit/bootstrap.php (1)
33-33: LGTM! Plugin file path updated correctly.The path change aligns with the renaming effort described in the PR objectives and is consistent with the updates in other files (e.g., bin/build-prod-zip.sh).
As I mentioned in this comment, I think that mostly |
|
I think that it'll largely be OpenAI. For POS, I think that we'll want to pull stuff to Woo core. |
|
If you see this message, please run this command :) git remote set-url origin [email protected]:woocommerce/woocommerce-product-feed-for-openai.git |
Description
There were a few remaining instances of names starting with OpenAi, including the main plugin file.
This PR addresses them.
Testing instructions
npm install&composer installshould not be broken.buildshould load the new main file.Summary by CodeRabbit
Documentation
Chores
Build / Tests