[INFRA-3653] upload-artifact needs update

[asurak]

The upload-artifact v3 is EoL and needs to be replaced by v4 version. The recommendation is to change the pin from a8a3f3ad30e3422c9c7b888a15615d19a852ae32 to 65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08. The rest of changes in https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changes does not seem impactful.

Patch:

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index cf1d6d9..fc121d4 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -55,7 +55,7 @@ jobs:
           make all install -j $(nproc); \
           "

-      - uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # pin@v3
+      - uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # pin@v4.6.0
         with:
           if-no-files-found: error
           name: orb-provison-artifacts${{ matrix.extra-version }}

cc @ik-work-gh

[asurak]

relates to https://linear.app/worldcoin/issue/INFRA-3653/[action-required]-actions-artifacts-v3-is-closing-down-january-30-2025