Skip to content

Incorrect critical rate/dmg values #3

@Peacerekam

Description

@Peacerekam

After doing basic example

const genshin = require("genshin_panel");

let attribute = new genshin.AttributeBuilder()
    .character(keqing)
    .weapon(weapon)
    .artifact(art1)
    .artifact(art2)
    .artifact(art3)
    .artifact(art4)
    .artifact(art5)
    .build()

the attribute.critical and attribute.criticalDamage show incorrect values.

in crit dmg case it looks like calculation done is:
0.884 + 59 => 59.88 instead of 88.4 + 59 => 147,4

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions