Merge pull request #142 from MotaWord/master

refactor deprecated join() usage

Author: schlessera

lib/cli/Arguments.php

@@ -482,7 +482,7 @@ private function _parseOption($option) {
 			}
 		}
 
-		$this[$option->key] = join($values, ' ');
+		$this[$option->key] = join(' ', $values);
 		return true;
 	}
 }

lib/cli/arguments/HelpScreen.php

@@ -56,7 +56,7 @@ public function render() {
 		array_push($help, $this->_renderFlags());
 		array_push($help, $this->_renderOptions());
 
-		return join($help, "\n\n");
+		return join("\n\n", $help);
 	}
 
 	private function _renderFlags() {
@@ -97,7 +97,7 @@ private function _renderScreen($options, $max) {
 			array_push($help, $formatted);
 		}
 
-		return join($help, "\n");
+		return join("\n", $help);
 	}
 
 	private function _consume($options) {
@@ -111,7 +111,7 @@ private function _consume($options) {
 				array_push($names, '-' . $alias);
 			}
 
-			$names = join($names, ', ');
+			$names = join(', ', $names);
 			$max = max(strlen($names), $max);
 			$out[$names] = $settings;
 		}

lib/cli/arguments/InvalidArguments.php

@@ -38,6 +38,6 @@ public function getArguments() {
 	private function _generateMessage() {
 		return 'unknown argument' .
 			(count($this->arguments) > 1 ? 's' : '') .
-			': ' . join($this->arguments, ', ');
+			': ' . join(', ', $this->arguments);
 	}
 }