Skip to content

Where/how to add 3rd party PHP packages used by wprig components in the /inc folder? #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seanrasmussen opened this issue Sep 22, 2019 · 3 comments

Comments

@seanrasmussen
Copy link

I notice that the composer vendor folder is not included in the production build....

Say I have a package that I want to use in a component, do I use a normal composer/vendor install, or do I manually copy the files into the component folder?

Some docs on this workflow would be great!

@ataylorme
Copy link

I notice that the composer vendor folder is not included in the production build

I've been thinking about this and I think the best approach would be for the production build step to copy composer.lock to the production build directory then run composer install --no-dev, rather than copying the vendor directory.

If I make a PR that does that, can you help test it @seanrasmussen?

@seanrasmussen
Copy link
Author

Sure, I'd be happy to help test it... with the disclaimer that I am a bit new to OOP PHP :-)

Just curious -- would that mean that the bundle.zip would also have the vendor (production) folder?

@ataylorme
Copy link

would that mean that the bundle.zip would also have the vendor (production) folder?

Yes, it would since the .zip is created at the end of the production build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants