-
Notifications
You must be signed in to change notification settings - Fork 367
Fix: Correct file paths in custom layout docs for versions 6.0.0 and 6.1.0 (Product IS issue #16460) #5701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Correct file paths in custom layout docs for versions 6.0.0 and 6.1.0 (Product IS issue #16460) #5701
Conversation
…6.1.0 (product-is#16460)
|
wso2-engineering-bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
WalkthroughDocumentation updates for Identity Server 6.0.0 and 6.1.0 customize login portal instructions. File paths redirected from non-Java components to Java-based component structure. Build working directory and deployment paths updated to align with new directory layout. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
en/identity-server/6.1.0/docs/references/extend/rebranding/customizable-login-portal.md (1)
124-128: Path corrections align with Java-based structure; minor grammar refinement needed.The path updates correctly reflect the migration to Java-based project layout. However, line 126 has a grammar issue: "Build should be succeeded" is awkward phrasing.
Apply this diff to improve clarity:
- 2. Navigate to `<IDENTITY-APPS-HOME>` directory and build the source code using `mvn clean install` command (Build should be succeeded for further steps). + 2. Navigate to `<IDENTITY-APPS-HOME>` directory and build the source code using `mvn clean install` command. The build must succeed to proceed to the next step.This rephrasing clarifies the requirement more naturally while maintaining the same intent.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
en/identity-server/6.0.0/docs/references/extend/rebranding/customizable-login-portal.md(1 hunks)en/identity-server/6.1.0/docs/references/extend/rebranding/customizable-login-portal.md(1 hunks)
🔇 Additional comments (1)
en/identity-server/6.0.0/docs/references/extend/rebranding/customizable-login-portal.md (1)
124-128: Path corrections align with Java-based project structure.The updates to lines 124, 126, and 128 correctly reflect the migration to Java-based component paths. The three-step sequence is logically sound:
- Copy custom layout from deployment → source (line 124)
- Build from repository root (line 126)
- Deploy compiled output back to deployment directory (line 128)
The path consistency (both lines 124 and 128 now include
/java/) and the move of the build step to the root directory align with standard Maven multi-module project practices.To ensure the documented paths match the actual repository structure, please verify that:
- The directory
<IDENTITY-APPS-HOME>/java/components/login-portal-layouts/layoutsexists- The directory
<IDENTITY-APPS-HOME>/java/apps/authentication-portal/src/main/webapp/extensions/layouts/customexists- The
mvn clean installcommand from<IDENTITY-APPS-HOME>root produces artifacts in the path specified on line 128Since the PR indicates mkdocs build succeeded, these paths are likely correct, but manual verification would confirm they align with the actual Identity Server 6.0.0 source structure.
|
Path updates done via this PR are invalid. |
This PR was automatically generated by Claude AI.
java/components/login-portal-layouts/layoutsandjava/apps/authentication-portal/src/main/webapp/extensions/layouts/custominstead of the incorrect paths.Changes Made
Version 6.0.0 and 6.1.0
Updated
en/identity-server/{version}/docs/references/extend/rebranding/customizable-login-portal.md:Step 3.a (now 3.1):
<IDENTITY-APPS-HOME>/components/login-portal-layouts/layouts<IDENTITY-APPS-HOME>/java/components/login-portal-layouts/layoutsStep 3.b (now 3.2):
<IDENTITY-APPS-HOME>/components/login-portal-layoutsdirectory<IDENTITY-APPS-HOME>directoryStep 3.c (now 3.3):
<IDENTITY-APPS-HOME>/apps/authentication-portal/src/main/webapp/extensions/layouts/custom<IDENTITY-APPS-HOME>/java/apps/authentication-portal/src/main/webapp/extensions/layouts/customSummary by CodeRabbit