Add option to hide menubar

[ghost]

How can I add the option to hide the menubar for GTKTerm in the source code similiar to konsole terminal application for example under the view menu in GTKTerm?

[Jeija]

The patch below (apply with git apply filename.patch) will get you something like this, you can toggle the menu bar with F11:

I don't think this functionality is really necessary / relevant for most users though, so I'm not sure if we should implement it in the master branch. I'm open to feedback on this though.

From fcbe4ee744d8d72a47bf3824d23e81f6a332e6ab Mon Sep 17 00:00:00 2001
From: Jeija <[email protected]>
Date: Sun, 8 Jan 2023 10:24:26 +0100
Subject: [PATCH] Add functionality to toggle menu bar visibility with F11

---
 src/interface.c | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/src/interface.c b/src/interface.c
index 32b8a24..d41c3fe 100644
--- a/src/interface.c
+++ b/src/interface.c
@@ -88,6 +88,7 @@ gboolean timestamp_on = 0;
 GtkWidget *StatusBar;
 GtkWidget *signals[6];
 static GtkWidget *Hex_Box;
+static GtkWidget *menu;
 GtkWidget *searchBar;
 GtkWidget *scrolled_window;
 GtkWidget *Fenetre;
@@ -126,6 +127,7 @@ void view_radio_callback(GtkAction *action, gpointer data);
 void view_hexadecimal_chars_radio_callback(GtkAction* action, gpointer data);
 void view_index_toggled_callback(GtkAction *action, gpointer data);
 void view_send_hex_toggled_callback(GtkAction *action, gpointer data);
+void view_hide_menubar_toggled_callback(GtkAction *action, gpointer data);
 void initialize_hexadecimal_display(void);
 gboolean Send_Hexadecimal(GtkWidget *, GdkEventKey *, gpointer);
 gboolean pop_message(void);
@@ -197,7 +199,8 @@ const GtkToggleActionEntry menu_toggle_entries[] =
 
 	/* View Menu */
 	{"ViewIndex", NULL, N_("Show _index"), NULL, NULL, G_CALLBACK(view_index_toggled_callback), FALSE},
-	{"ViewSendHexData", NULL, N_("_Send hexadecimal data"), NULL, NULL, G_CALLBACK(view_send_hex_toggled_callback), FALSE}
+	{"ViewSendHexData", NULL, N_("_Send hexadecimal data"), NULL, NULL, G_CALLBACK(view_send_hex_toggled_callback), FALSE},
+	{"ViewHideMenubar", NULL, N_("_Hide menu bar"), "F11", NULL, G_CALLBACK(view_hide_menubar_toggled_callback), FALSE}
 };
 
 const GtkRadioActionEntry menu_view_radio_entries[] =
@@ -271,6 +274,7 @@ static const char *ui_description =
     "      <menuitem action='ViewIndex'/>"
     "      <separator/>"
     "      <menuitem action='ViewSendHexData'/>"
+	"      <menuitem action='ViewHideMenubar'/>"
     "    </menu>"
     "    <menu action='Help'>"
     "      <menuitem action='HelpAbout'/>"
@@ -298,6 +302,14 @@ void view_send_hex_toggled_callback(GtkAction *action, gpointer data)
 		gtk_widget_hide(GTK_WIDGET(Hex_Box));
 }
 
+void view_hide_menubar_toggled_callback(GtkAction *action, gpointer data)
+{
+	if (gtk_toggle_action_get_active(GTK_TOGGLE_ACTION(action)))
+		gtk_widget_hide(GTK_WIDGET(menu));
+	else
+		gtk_widget_show(GTK_WIDGET(menu));
+}
+
 void view_index_toggled_callback(GtkAction *action, gpointer data)
 {
 	show_index = gtk_toggle_action_get_active(GTK_TOGGLE_ACTION(action));
@@ -465,7 +477,7 @@ void terminal_popup_menu_callback(GtkWidget *widget, gpointer data)
 
 void create_main_window(void)
 {
-	GtkWidget *menu, *main_vbox, *label;
+	GtkWidget *main_vbox, *label;
 	GtkWidget *hex_send_entry;
 	GtkAccelGroup *accel_group;
 	GError *error;
-- 
2.39.0

[ghost]

This was exactly what I wanted, thank you!