Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure on 5.18.x #3

Open
garfieldnate opened this issue Aug 29, 2013 · 9 comments
Open

Test failure on 5.18.x #3

garfieldnate opened this issue Aug 29, 2013 · 9 comments

Comments

@garfieldnate
Copy link

I know you're probably already aware of the failing tests on Perl 5.18.x, but I thought I'd bring it up just in case. Your module seems to be the only one that allows such simple creation of files with unicode names, and I would very much like to use it in the latest Perl distribution.
I inspected the source for _ConsoleOut and unfortunately I just don't have the knowledge required to send a patch. Let me know if there's any way I can help.

@rdboisvert
Copy link

Not sure if you will get an answer but you might want to consider Win32-LongPath which is based on the good work done in Win32-Unicode.

@garfieldnate
Copy link
Author

Oh good! Version 0.03 of that installs cleanly. Thanks!
It would still be a shame to let this distribution stay failing. It's only the print method; everything else still works!

@rdboisvert
Copy link

I tried to get the attention of the developer months ago to implement a fix I had engineered. Unfortunately, it seems like this site has been abandoned.

Perhaps you can use Win32-Unicode for printing even though it fails the test cycle. I will look into duplicating the print function in my code.

@garfieldnate
Copy link
Author

It's not that I need the print function, it's that since it doesn't work some tests fail and the distro won't install cleanly.
Would you mind posting your fix here? I would like to learn from you :)

@rdboisvert
Copy link

Actually, I wasn't fixing something so much as enhancing. When I didn't get a response after months I decided to start from scratch.

I haven't installed Perl 5.18 yet but if you can attach the error messages I might be able to get you a fix.

@garfieldnate
Copy link
Author

Here's the one from CPAN Testers.
How does your module improve upon the functionality in Win32::Unicode::File? Since this distribution is mentioned pretty often, it might help to have a comparison in your POD.

@rdboisvert
Copy link

Since the error report applies to Strawberry Perl my guess is that it is a problem related to Strawberry. Is that the same version you are using? Does it generate the same errors in your environment? Looking at the code it appears that Yuji tried to support Strawberry wherever he could, coding around differences where necessary. Probably a change in Strawberry bumped into one of his workarounds.

Unfortunately, I don't have the resources to track this problem down but if you are not using Strawberry, you may not have any problems with the module.

Your comments about comparing the two modules are appreciated. I tried to make that distinction in the POD but I will give it further thought. Basically, Win32-LongPath is all about very long paths and Unicode. It allows the coder to use functions that are very similar to the native Perl file functions but do not require any special handling if the file path contains Unicode or is very long (over 255 characters).

@garfieldnate
Copy link
Author

I get the exact same error, and I'm using 5.18.1.1. Can you point to a part of the code that is Strawberry specific? I don't know what the differences are between writing for Strawberry and writing for ActiveState or other Win32 distributions.
Your module is very nice and I plan to use it from now on:)

@vyv03354
Copy link

I had to downgrade to Strawberry Perl 5.16.3.1 to work around the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants