CA-417390: No RRD metric for vGPU migration with local storage (#6680)

minglumlu · web-flow · commit 39b166a5e370 · 2025-09-23T05:12:56.000Z
The "vgpu_map" can be empty for an intra-pool migration. This was missed
previously because XenCenter indeed prepares non-empty "vgpu_map" for
intra-pool migration with shared storage. But it prepares empty
"vgpu_map" for intra-pool migration with local storage.
diff --git a/ocaml/xapi/message_forwarding.ml b/ocaml/xapi/message_forwarding.ml
@@ -2624,7 +2624,7 @@ functor
                   assert_can_migrate ~__context ~vm ~dest ~live ~vdi_map
                     ~vif_map ~vgpu_map ~options
               ) ;
-              if vgpu_map <> [] then
+              if Db.VM.get_VGPUs ~__context ~self:vm <> [] then
                 Xapi_stats.incr_pool_vgpu_migration_count () ;
               forward_migrate_send ()
           )

Original file line number	Diff line number	Diff line change
`@@ -2624,7 +2624,7 @@ functor`
`2624`	`2624`	`assert_can_migrate ~__context ~vm ~dest ~live ~vdi_map`
`2625`	`2625`	`~vif_map ~vgpu_map ~options`
`2626`	`2626`	`) ;`
`2627`		`- if vgpu_map <> [] then`
	`2627`	`+ if Db.VM.get_VGPUs ~__context ~self:vm <> [] then`
`2628`	`2628`	`Xapi_stats.incr_pool_vgpu_migration_count () ;`
`2629`	`2629`	`forward_migrate_send ()`
`2630`	`2630`	`)`