Forge download version

[azukaar]

Only version 1.12.1 seems to work on forge download.

For 1.7.10 I get :

(node:16712) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'path' of undefined
    at LibraryManager.installMinecraftLibraries (C:\Users\azuka\Documents\dev\yanncraft\node_modules\minecraft-client\dist\utils\Libraries.js:35:79)
(node:16712) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:16712) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

for 1.12.2 I get :

[19:43:35] [main/INFO]: Loading tweak class name net.minecraftforge.fml.common.launcher.FMLTweaker
[19:43:35] [main/INFO]: Using primary tweak class name net.minecraftforge.fml.common.launcher.FMLTweaker
[19:43:35] [main/INFO]: Calling tweak class net.minecraftforge.fml.common.launcher.FMLTweaker
Exception in thread "main"
Exception: java.lang.NoSuchMethodError thrown from the UncaughtExceptionHandler in thread "main"

[xcf-t]

I just found out that the forge filenames are inconsistent. For example 1.12.2 would have the filename forge-1.12.2-14.23.5.2769-installer.jar and 1.7.10 would have forge-1.7.10-10.13.4.1614-1.7.10-installer.jar. I'm trying to fix this asap.

[xcf-t]

Found out the source for the 1.12.2 error:
The client currently uses all the libraries in the libraries/ folder which means that launching 1.12.2 after installing 1.7.10 will lead to a crash. I'll fix this by using the libraries given in the manifest file.

[xcf-t]

I hopefully fixed this in the newest version (f5f95ce). Can you confirm, if this still is the case in the latest version (Should be 2.4.1 on npm)?

Version 1.7.10 is still not working with Forge.

[azukaar]

This line is failing in latest version :

const download = require("download"); //TODO: Replace with fetch

On 2.4.1, I have no more errors in the terminal but the game doesnt start anymore (1.12.1 or 1.12.2) after successfully going thought every step. As if client.launch wasnt doing anything

[xcf-t]

Should be fixed in 37d9ab2 (2.5.2)

[azukaar]

Okay this one works, but seems to have the same issue where client.launchdoesn't do anything and there's no error in the terminal either

[azukaar]

Nevermind, the reasons why I had no errors is because you added the redirectionOutput boolean. But I do get an error (1.12.1 and 1.12.2) :

Error: Could not find or load main class net.minecraft.launchwrapper.Launch

Also I think I found why 1.7.10 is not working, I will test and make a PR once I can start any version

[azukaar]

Error

Error: Could not find or load main class net.minecraft.launchwrapper.Launch

Still occuring in version 2.6.2 for me ?