Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inquiry on Combining Hybrid O2M and Relation Attention Mask #38

Open
Anchor1566 opened this issue Jan 24, 2025 · 1 comment
Open

Inquiry on Combining Hybrid O2M and Relation Attention Mask #38

Anchor1566 opened this issue Jan 24, 2025 · 1 comment
Labels
question Further information is requested

Comments

@Anchor1566
Copy link

Question

Thank you for your remarkable work and elegant implementation !

While reproducing and experimenting with your approach, I encountered a question regarding the combination of the hybrid O2M (One-to-Many) mechanism and the proposed relation attention mask. Specifically, I observed that when implemented separately, both components contribute to performance improvements. However, when combined, the results show a noticeable decline. I have tried adjusting the weights of the O2M component, but the issue persists.

Could there be any subtle details or considerations that I might have overlooked when integrating these two components? Any insights or suggestions you could provide would be greatly appreciated.

Thank you in advance for your time and response. Also, I’d like to take this opportunity to wish you an early Happy Chinese New Year! May the coming year bring even more wonderful things to your life and research endeavors.

Additional

No response

@Anchor1566 Anchor1566 added the question Further information is requested label Jan 24, 2025
@xiuqhou
Copy link
Owner

xiuqhou commented Jan 25, 2025

Hi @Anchor1566 Thank you for your kind words and thoughtful message. I truly appreciate your interest in our work.

Regarding your question about O2M and relation attention mask, I found only when O2O branch adopts Relation and O2M branch skips Relation, performance is improved. If both branches use Relation or not use Relation, the performance may be degraded. You can refer to the implementation in this repo to integrate the two modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants