Skip to content

Conversation

@joe94
Copy link
Member

@joe94 joe94 commented Aug 14, 2020

No description provided.

@joe94 joe94 marked this pull request as draft August 14, 2020 02:20
@joe94 joe94 self-assigned this Aug 14, 2020
@joe94 joe94 linked an issue Aug 14, 2020 that may be closed by this pull request
@joe94 joe94 changed the title Feature/device Update WRP Spec for deviceID Aug 14, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

source | The device_id name of the device originating the request or response.
dest | The device_id name of the target device of the request or response.
content_type | (optional) The media type of the payload.
source | The device_id name of the device originating the request or response (i.e. dns:tr1d1um.example.net for inbound messages).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if parodus is or plans to use the source field (dns:tr1d1um.example.net) on inbound messages.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought parodus uses the source at the very least to fill in the destination for the response wrp it sends. I could be wrong.

@joe94 joe94 added the enhancement New feature or request label Aug 14, 2020
source | The device_id name of the device originating the request or response (i.e. dns:tr1d1um.example.net for inbound messages).
dest | The device_id name of the target device of the request or response (i.e. mac:112233445566/config for inbound messages).
device_id | The canonical device ID (i.e. mac:112233445566) involved in this envelope. It defers from source or dest in that no further parsing is required to extract the ID from the value.
content_type | (optional) The media type of the payload. If not specified on inbound messages, `application/octet-stream` is used as default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we were only adding this for events? Is this also being added to request-responses?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, found the pull request (xmidt-org/webpa-common#508). But isn't it filled in for outbound messages, not inbound?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ schmidtw
❌ Joel Unzain


Joel Unzain seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update WRP simple messages spec

5 participants