-
Notifications
You must be signed in to change notification settings - Fork 5
Update WRP Spec for deviceID #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
content/docs/wrp/simple-messages.md
Outdated
| source | The device_id name of the device originating the request or response. | ||
| dest | The device_id name of the target device of the request or response. | ||
| content_type | (optional) The media type of the payload. | ||
| source | The device_id name of the device originating the request or response (i.e. dns:tr1d1um.example.net for inbound messages). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if parodus is or plans to use the source field (dns:tr1d1um.example.net) on inbound messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought parodus uses the source at the very least to fill in the destination for the response wrp it sends. I could be wrong.
| source | The device_id name of the device originating the request or response (i.e. dns:tr1d1um.example.net for inbound messages). | ||
| dest | The device_id name of the target device of the request or response (i.e. mac:112233445566/config for inbound messages). | ||
| device_id | The canonical device ID (i.e. mac:112233445566) involved in this envelope. It defers from source or dest in that no further parsing is required to extract the ID from the value. | ||
| content_type | (optional) The media type of the payload. If not specified on inbound messages, `application/octet-stream` is used as default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we were only adding this for events? Is this also being added to request-responses?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, found the pull request (xmidt-org/webpa-common#508). But isn't it filled in for outbound messages, not inbound?
Co-authored-by: Kristina Pathak <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
|
Joel Unzain seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |








No description provided.