XEP-0199: Full support client 2 server pings.

[eleksir]

As far as I see send and recieve ping message abilities themselves are implemented. But currently client part completely lacks support for periodic sending procedure that is required for complete implementation of XEP-0199. I mean 4.2 section - Client 2 Server pings.

XEP-0199 is optional by standard which means that server can omit support of this xep, but in practice I never saw such a server in a wild - most of them require pings or after some period of inactivity server closes connection. (Which is annoyng if you client sitting there for some notable period of time, eg it is bot.)

So having full support of XEP-0199 directly built-in to NewClient() is quite helpful (ofcorse there must be a option to toggle this feature).

[mdosch]

@eleksir
Not sure what you expect. You could already run a goroutine which periodically calls PingC2S. Can you have a look at the periodic-pings branch and check whether that is what you think of?

Also: Do you have an example of a public server showing the problematic behavior for testing? I never experienced something like that with my bots.

[eleksir]

Do you have an example of a public server showing the problematic behavior for testing?

On a top of my head it is jabber.ru (at least they did that ~half of year ago, when i touch this topic last time)

[eleksir]

Can you have a look at the periodic-pings branch and check whether that is what you think of?
In one of comments here you talk about life/work balance that eats almost all hobby time... well, same thing.

In my queue sync of current state of this lib to my 2 bots. (since I do not want to support my own version of lib) Anyway, as soon as i have a time for it to play.

[eleksir]

Can you have a look at the periodic-pings branch and check whether that is what you think of?

Yup, exactly!
I've got couple of PRs, they're cosmetic, but convinient.

[eleksir]

Also it can be useful to have xep-0410 MUC Self-Ping (Schrödinger's Chat).
But as far as I try to implement it on bot' side, it was not very good solution. If there is more than 1 client from the same account in one muc, situation tends to be a bit uncertain. So I suppose it can be left unimplemented. (In my experience I did not encounter any troubles without active xep-0410)

[mdosch]

Can you have a look at the periodic-pings branch and check whether that is what you think of?

Yup, exactly! I've got couple of PRs, they're cosmetic, but convinient.

Thanks for checking.

Can you have a look at the periodic-pings branch and check whether that is what you think of?

Yup, exactly! I've got couple of PRs, they're cosmetic, but convinient.

Will try to have a look in the next days.

Also it can be useful to have xep-0410 MUC Self-Ping (Schrödinger's Chat). But as far as I try to implement it on bot' side, it was not very good solution. If there is more than 1 client from the same account in one muc, situation tends to be a bit uncertain. So I suppose it can be left unimplemented. (In my experience I did not encounter any troubles without active xep-0410)

I think I would also rather implement this in the client/bot. Actually it should not be an issue if you have more clients joined.