Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ligatures have a maximum width #5246

Open
Tyriar opened this issue Dec 12, 2024 · 2 comments · Fixed by #5278
Open

Ligatures have a maximum width #5246

Tyriar opened this issue Dec 12, 2024 · 2 comments · Fixed by #5278
Assignees

Comments

@Tyriar
Copy link
Member

Tyriar commented Dec 12, 2024

VS Code issue: microsoft/vscode#235988

With ligatures enabled:Image

With ligatures disabled:Image

@Tyriar
Copy link
Member Author

Tyriar commented Jan 6, 2025

This is caused by this condition since the texture size is hardcoded to 512:

// Allow 1 cell width per character, with a minimum of 2 (CJK), plus some padding. This is used
// to draw the glyph to the canvas as well as to restrict the bounding box search to ensure
// giant ligatures (eg. =====>) don't impact overall performance.
const allowedWidth = Math.min(this._config.deviceCellWidth * Math.max(chars.length, 2) + TMP_CANVAS_GLYPH_PADDING * 2, this._textureSize);

@Tyriar
Copy link
Member Author

Tyriar commented Jan 30, 2025

This is still an issue due to the maximum texture size being too small on common machines (macbooks).

@Tyriar Tyriar reopened this Jan 30, 2025
@Tyriar Tyriar removed this from the 6.0.0 milestone Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant