add login and pro platform features to react flow docs #699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@dimaMachina is attempting to deploy a commit to the xyflow Team on Vercel. A member of the Team first needs to authorize it. |
dimaMachina
commented
May 14, 2025
Comment on lines
+26
to
+31
| // Must set `nhostRefreshTokenExpiresAt` | ||
| // https://github.com/nhost/nhost/blob/c0635ae1c7d5fe3bd889d11291ebc6978e866647/packages/hasura-auth-js/src/machines/authentication/machine.ts#L647C15-L649C81 | ||
| // const nextRefresh = new Date(Date.now() + session.accessTokenExpiresIn * 1_000) | ||
| // const value = nextRefresh.toISOString(); | ||
| // console.log({value}) | ||
| // cookieStore.set(NHOST_JWT_EXPIRES_AT_KEY, nextRefresh.getTime(), { path: '/' }) |
There was a problem hiding this comment.
Suggested change
| // Must set `nhostRefreshTokenExpiresAt` | |
| // https://github.com/nhost/nhost/blob/c0635ae1c7d5fe3bd889d11291ebc6978e866647/packages/hasura-auth-js/src/machines/authentication/machine.ts#L647C15-L649C81 | |
| // const nextRefresh = new Date(Date.now() + session.accessTokenExpiresIn * 1_000) | |
| // const value = nextRefresh.toISOString(); | |
| // console.log({value}) | |
| // cookieStore.set(NHOST_JWT_EXPIRES_AT_KEY, nextRefresh.getTime(), { path: '/' }) |
dimaMachina
commented
May 14, 2025
Comment on lines
+30
to
+36
| // const refreshTokenValue = cookieStore.get(NHOST_REFRESH_KEY)?.value; | ||
| // if (refreshTokenValue) { | ||
| // const { error, session } = await nhost.auth.refreshSession(refreshTokenValue); | ||
| // if (error) { | ||
| // console.error(error); | ||
| // } | ||
| // } |
There was a problem hiding this comment.
Suggested change
| // const refreshTokenValue = cookieStore.get(NHOST_REFRESH_KEY)?.value; | |
| // if (refreshTokenValue) { | |
| // const { error, session } = await nhost.auth.refreshSession(refreshTokenValue); | |
| // if (error) { | |
| // console.error(error); | |
| // } | |
| // } |
dimaMachina
commented
May 14, 2025
| }; | ||
|
|
||
| loadFiles(); | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps |
There was a problem hiding this comment.
Suggested change
| // eslint-disable-next-line react-hooks/exhaustive-deps | |
| // eslint-disable-next-line react-hooks/exhaustive-deps -- only on mount |
dimaMachina
commented
May 14, 2025
| "file-saver": "2.0.5", | ||
| "jszip": "3.10.1", | ||
| "@apollo/client": "3.7.15", | ||
| "fathom-client": "3.5.0", |
There was a problem hiding this comment.
i think we already have it
dimaMachina
commented
May 14, 2025
| "next-sitemap": "^4.2.3", | ||
| "nextra": "^4.3.0-alpha.22", | ||
| "nextra-theme-docs": "^4.3.0-alpha.22", | ||
| "react": "^18.3.1", | ||
| "react-dom": "^18.3.1", | ||
| "react-icons": "^5.5.0", | ||
| "timeago-react": "^3.0.7", | ||
| "ui-components": "workspace:*", |
There was a problem hiding this comment.
ui components not used in this repo
chrtze
changed the title
chrtze
reviewed
May 20, 2025
| teamPlan: SubscriptionPlan; | ||
| }> { | ||
| const nhost = await getNhost(); | ||
| const userId = nhost.auth.getUser()!.id!; |
There was a problem hiding this comment.
Suggested change
| const userId = nhost.auth.getUser()!.id!; | |
| if (!userId) { | |
| return { | |
| plan: SubscriptionPlan.FREE, | |
| teamPlan: SubscriptionPlan.FREE, | |
| }; | |
| } |
There was a problem hiding this comment.
If there is no userId, for example when user is signed out, I getting a graphql error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #690
Important
don't forget to setup
NEXT_PUBLIC_NHOST_SUBDOMAINandNEXT_PUBLIC_NHOST_REGIONenv variables!reactflow.comUserProvider(I previously proposed it)NhostClient's storage type changed tocookieso we can authenticate in RSC too/dashboard/...will redirect to/signin(when NOT authenticated)(auth)will redirect to/dashboard(when authenticated)/dashboardUpdated
No need to refactor everything to server actions (or did I miss something?)Let’s combine Sign In and Sign Out into 1 button? it takes up a lot of space in the header